-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iterative write and parallel I/O tutorial #1633
Conversation
…aChunkIterator to setup data for parallel write
Codecov Report
@@ Coverage Diff @@
## dev #1633 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 25 25
Lines 2534 2534
Branches 481 481
=======================================
Hits 2314 2314
Misses 139 139
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@CodyCBakerPhD while going through the iterative write tutorial to fix a few issues, I noticed that we were not discussing the GenericDataChunkIterator here. I added a few references to the corresponding tutorial, however, it would be nice if we could also show the usage of GenericDataChunkIterator here. I think we could just update the "Convert large binary data arrays" section of the tutorial to use GenericDataChunkIterator instead of DataChunkIterator. If you have time, could you maybe just quickly add those changes to this PR. I think it should be a fairly simple change, but I figured since you are the expert in GenericDataChunkIterator it would be best if you could make that change. pynwb/docs/gallery/advanced_io/iterative_write.py Lines 465 to 563 in f4bbbd6
|
@rly thanks for the fixes |
* Check nwb_version on read (#1612) * Added NWBHDF5IO.nwb_version property and check for version on NWBHDF5IO.read * Updated icephys tests to skip version check when writing non NWBFile container * Add tests for NWB version check on read * Add unit tests for NWBHDF5IO.nwb_version property * Updated changelog Co-authored-by: Ryan Ly <[email protected]> * Bump setuptools from 65.4.1 to 65.5.1 (#1614) Bumps [setuptools](https://github.com/pypa/setuptools) from 65.4.1 to 65.5.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v65.4.1...v65.5.1) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * modify export.rst to have proper links to the NWBFile API docs (#1615) * Create project_action.yml (#1617) * Create project_action.yml * Update project_action.yml * Update project_action.yml * Update project_action.yml (#1620) * Update project_action.yml (#1623) * Project action (#1626) * Create project_action.yml * Update project_action.yml * Update project_action.yml * Update project_action.yml * Show recommended usaege for hdf5plugin in tutorial (#1630) * Show recommended usaege for hdf5plugin in tutorial * Update docs/gallery/advanced_io/h5dataio.py * Update docs/gallery/advanced_io/h5dataio.py Co-authored-by: Heberto Mayorquin <[email protected]> Co-authored-by: Ben Dichter <[email protected]> Co-authored-by: Heberto Mayorquin <[email protected]> * Update iterative write and parallel I/O tutorial (#1633) * Update iterative write tutorial * Update doc makefiles to clean up files created by the advanced io tutorial * Fix #1514 Update parallel I/O tutorial to use H5DataIO instead of DataChunkIterator to setup data for parallel write * Update changelog * Fix flake8 * Fix broken external links * Update make.bat * Update CHANGELOG.md * Update plot_iterative_write.py * Update docs/gallery/advanced_io/plot_iterative_write.py Co-authored-by: Ryan Ly <[email protected]> * Update project_action.yml (#1632) * nwb_schema_2.6.0 * Update CHANGELOG.md * remove Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Oliver Ruebel <[email protected]> Co-authored-by: Ryan Ly <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Dichter <[email protected]> Co-authored-by: Heberto Mayorquin <[email protected]>
Motivation
This PR is related to HDMF #623 and Fix #1514
GenericDataChunkIterator
and crosslink to the corresponding tutorial on HDMFHDF5IO.dataset
property to avoid having to close and reopen a fileplot_
prefix to make sure outputs are captured directly from the tutorial rather than being harcoded in the tutorialHow to test the behavior?
Build the docs
Checklist
flake8
from the source directory.