Skip to content

Conversation

@jiel-nv
Copy link
Contributor

@jiel-nv jiel-nv commented Jan 22, 2026

Fixes #721.

The linecache scenario (which Jupyter uses) was missed during vendoring via PR #457. Port in the upstream Numba approach of adding inspect.getsourcelines() to handle this case (original PR numba/numba#9861) with modifications so that it serves as the main/only approach instead of fallback.

Jupyter notebook cells have virtual filenames (e.g., ) that don't exist on disk. IPython registers cell source in Python's linecache module, which inspect.getsourcelines() uses internally. The previous implementation only used open() to read source files, causing lookups to fail for notebook cells.

Using inspect.getsourcelines() as the main approach rather than a fallback simplifies the code since it handles both disk files and linecache entries uniformly.

Added test_linecache_source() in test_debuginfo.py to simulate the Jupyter scenario by registering source in linecache and verifying that no NumbaDebugInfoWarning is raised when compiling a kernel with debug=True.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 22, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 22, 2026

Greptile Summary

Replaces file-based source reading with inspect.getsourcelines() to fix missing line info in Jupyter notebook cells. The previous implementation used open() to read source files directly, which failed for virtual filenames like <ipython-input-X-Y> that Jupyter uses. The new approach leverages inspect.getsourcelines() which internally uses linecache, handling both regular disk files and IPython's registered cell sources uniformly.

  • Refactored FindDefFirstLine.__init__() to accept name and firstlineno parameters instead of code object, simplifying the interface
  • Both get_func_body_first_lineno() and get_func_def_lineno() now use inspect.getsourcelines() as the primary approach rather than a fallback
  • Adjusted line number calculations to account for the offset returned by inspect.getsourcelines()
  • Added test_linecache_source() that simulates Jupyter's linecache registration to verify no NumbaDebugInfoWarning is raised

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are well-structured and follow the upstream Numba approach. The refactoring simplifies the code by using a unified method for both disk files and linecache entries. The implementation correctly handles offset adjustments, includes proper error handling, and adds a comprehensive test that validates the fix for the reported issue.
  • No files require special attention

Important Files Changed

Filename Overview
numba_cuda/numba/cuda/misc/firstlinefinder.py Replaced file-based source reading with inspect.getsourcelines() to support Jupyter notebooks via linecache
numba_cuda/numba/cuda/tests/cudapy/test_debuginfo.py Added test_linecache_source() to verify debug info works with linecache-registered sources

@jiel-nv
Copy link
Contributor Author

jiel-nv commented Jan 22, 2026

/ok to test ec4d8f3

@gmarkall gmarkall added the 3 - Ready for Review Ready for review by team label Jan 23, 2026
@gmarkall gmarkall self-assigned this Jan 23, 2026
@gmarkall gmarkall self-requested a review January 23, 2026 00:02
@gmarkall
Copy link
Contributor

gmarkall commented Jan 23, 2026

I'm getting a really weird traceback when I try to run the reproducer from the bug report in a Jupyter notebook.

It would be surprising if this PR was the cause of the issue, but perhaps it exposes another strange issue.

Edit: my local environment needed an update for recent changes. There is no issue.

(traceback deleted)

@gmarkall
Copy link
Contributor

gmarkall commented Jan 23, 2026

It's OK, it turns out my local main was out of date. We have some other regression which I'll look into separately.

Copy link
Contributor

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@gmarkall gmarkall added 4 - Waiting on CI Waiting for a CI run to finish successfully and removed 3 - Ready for Review Ready for review by team labels Jan 23, 2026
@gmarkall gmarkall enabled auto-merge (squash) January 23, 2026 11:40
@gmarkall gmarkall merged commit 2357413 into NVIDIA:main Jan 23, 2026
207 of 209 checks passed
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Jan 27, 2026
- Add Python 3.14 to the wheel publishing matrix (NVIDIA#750)
- feat: swap out internal device array usage with `StridedMemoryView` (NVIDIA#703)
- Fix max block size computation in `forall` (NVIDIA#744)
- Fix prologue debug line info pointing to decorator instead of def line (NVIDIA#746)
- Fix kernel return type in DISubroutineType debug metadata (NVIDIA#745)
- Fix missing line info in Jupyter notebooks (NVIDIA#742)
- Fix: Pass correct flags to linker when debugging in the presence of LTOIR code (NVIDIA#698)
- chore(deps): add cuda-pathfinder to pixi deps (NVIDIA#741)
- fix: enable flake8-bugbear lints and fix found problems (NVIDIA#708)
- fix: Fix race condition in CUDA Simulator (NVIDIA#690)
- ci: run tests in parallel (NVIDIA#740)
- feat: users can pass `shared_memory_carveout` to @cuda.jit (NVIDIA#642)
- Fix compatibility with NumPy 2.4: np.trapz and np.in1d removed (NVIDIA#739)
- Pass the -numba-debug flag to libnvvm (NVIDIA#681)
- ci: remove rapids containers from conda ci (NVIDIA#737)
- Use `pathfinder` for dynamic libraries (NVIDIA#308)
- CI: Add CUDA 13.1 testing support (NVIDIA#705)
- Adding `pixi run test` and `pixi run test-par` support (NVIDIA#724)
- Disable per-PR nvmath tests + follow same test practice (NVIDIA#723)
- chore(deps): regenerate pixi lockfile (NVIDIA#722)
- Fix DISubprogram line number to point to function definition line (NVIDIA#695)
- revert: chore(dev): build pixi using rattler (NVIDIA#713) (NVIDIA#719)
- [feat] Initial version of the Numba CUDA GDB pretty-printer (NVIDIA#692)
- chore(dev): build pixi using rattler (NVIDIA#713)
- build(deps): bump the actions-monthly group across 1 directory with 8 updates (NVIDIA#704)
@gmarkall gmarkall mentioned this pull request Jan 27, 2026
kkraus14 pushed a commit that referenced this pull request Jan 28, 2026
- Add Python 3.14 to the wheel publishing matrix (#750)
- feat: swap out internal device array usage with `StridedMemoryView`
(#703)
- Fix max block size computation in `forall` (#744)
- Fix prologue debug line info pointing to decorator instead of def line
(#746)
- Fix kernel return type in DISubroutineType debug metadata (#745)
- Fix missing line info in Jupyter notebooks (#742)
- Fix: Pass correct flags to linker when debugging in the presence of
LTOIR code (#698)
- chore(deps): add cuda-pathfinder to pixi deps (#741)
- fix: enable flake8-bugbear lints and fix found problems (#708)
- fix: Fix race condition in CUDA Simulator (#690)
- ci: run tests in parallel (#740)
- feat: users can pass `shared_memory_carveout` to @cuda.jit (#642)
- Fix compatibility with NumPy 2.4: np.trapz and np.in1d removed (#739)
- Pass the -numba-debug flag to libnvvm (#681)
- ci: remove rapids containers from conda ci (#737)
- Use `pathfinder` for dynamic libraries (#308)
- CI: Add CUDA 13.1 testing support (#705)
- Adding `pixi run test` and `pixi run test-par` support (#724)
- Disable per-PR nvmath tests + follow same test practice (#723)
- chore(deps): regenerate pixi lockfile (#722)
- Fix DISubprogram line number to point to function definition line
(#695)
- revert: chore(dev): build pixi using rattler (#713) (#719)
- [feat] Initial version of the Numba CUDA GDB pretty-printer (#692)
- chore(dev): build pixi using rattler (#713)
- build(deps): bump the actions-monthly group across 1 directory with 8
updates (#704)

<!--

Thank you for contributing to numba-cuda :)

Here are some guidelines to help the review process go smoothly.

1. Please write a description in this text box of the changes that are
being
   made.

2. Please ensure that you have written units tests for the changes
made/features
   added.

3. If you are closing an issue please use one of the automatic closing
words as
noted here:
https://help.github.com/articles/closing-issues-using-keywords/

4. If your pull request is not ready for review but you want to make use
of the
continuous integration testing facilities please label it with `[WIP]`.

5. If your pull request is ready to be reviewed without requiring
additional
work on top of it, then remove the `[WIP]` label (if present) and
replace
it with `[REVIEW]`. If assistance is required to complete the
functionality,
for example when the C/C++ code of a feature is complete but Python
bindings
are still required, then add the label `[HELP-REQ]` so that others can
triage
and assist. The additional changes then can be implemented on top of the
same PR. If the assistance is done by members of the rapidsAI team, then
no
additional actions are required by the creator of the original PR for
this,
otherwise the original author of the PR needs to give permission to the
person(s) assisting to commit to their personal fork of the project. If
that
doesn't happen then a new PR based on the code of the original PR can be
opened by the person assisting, which then will be the PR that will be
   merged.

6. Once all work has been done and review has taken place please do not
add
features or make changes out of the scope of those requested by the
reviewer
(doing this just add delays as already reviewed code ends up having to
be
re-reviewed/it is hard to tell what is new etc!). Further, please do not
rebase your branch on main/force push/rewrite history, doing any of
these
   causes the context of any comments made by reviewers to be lost. If
   conflicts occur against main they should be resolved by merging main
   into the branch used for making the pull request.

Many thanks in advance for your cooperation!

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 - Waiting on CI Waiting for a CI run to finish successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Lineinfo missing in Jupyter notebook cells

2 participants