Skip to content

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 20, 2026

Remove rapids container usage from pixi/conda CI

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 20, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 20, 2026

/ok to test

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 20, 2026

/ok to test

@cpcloud cpcloud changed the title ci: remove rapids containres from conda ci ci: remove rapids containers from conda ci Jan 20, 2026
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 20, 2026

/ok to test

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Summary

Removes RAPIDS container infrastructure from conda CI workflow, transitioning to direct runner execution with pixi. The changes eliminate the rapidsai/ci-conda container, RAPIDS-specific environment variables (RAPIDS_ARTIFACTS_DIR, RAPIDS_COVERAGE_DIR, RAPIDS_TESTS_DIR), test report generation, and artifact upload steps. The test script is simplified by removing rapids-logger calls while maintaining the same test execution logic.

Key changes:

  • Workflow now runs directly on GitHub runners instead of RAPIDS containers
  • Removed unused container-options input parameter (still defined but no longer used)
  • Eliminated RAPIDS-specific steps: repository standardization, test report generation, and artifact uploads
  • Codecov step simplified to remove -s flag with RAPIDS_COVERAGE_DIR (coverage may not be collected without additional configuration)
  • Test script cleaned up with simpler logging approach

Confidence Score: 4/5

  • This PR is generally safe to merge with minimal risk of breaking CI
  • The changes cleanly remove RAPIDS infrastructure dependencies. However, the score is 4 rather than 5 because: (1) the unused container-options input parameter should be removed for cleanliness, and (2) codecov coverage collection needs verification since RAPIDS_COVERAGE_DIR was removed without confirming an alternative coverage directory is configured
  • Verify that .github/workflows/conda-python-tests.yaml codecov step still collects coverage correctly

Important Files Changed

Filename Overview
.github/workflows/conda-python-tests.yaml Removed rapids container configuration and related environment variables; workflow now runs directly on runner
ci/test_conda.sh Removed rapids-logger calls and simplified logging; script is cleaner and more focused

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. .github/workflows/conda-python-tests.yaml, line 30-33 (link)

    style: container-options input is no longer used since the container configuration was removed

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment on lines 115 to 124
@@ -143,8 +121,4 @@ jobs:
-v \
upload-process \
-C ${{ github.sha }} \
-s "${RAPIDS_COVERAGE_DIR}" \
--handle-no-reports-found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Verify codecov correctly finds coverage reports without the -s flag pointing to RAPIDS_COVERAGE_DIR. Tests may need to be configured to generate coverage files in the expected location.

@kkraus14 kkraus14 enabled auto-merge (squash) January 21, 2026 16:50
@kkraus14 kkraus14 merged commit 675addd into NVIDIA:main Jan 21, 2026
105 checks passed
@cpcloud cpcloud deleted the remove-rapids-containers-from-pixi branch January 23, 2026 16:34
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Jan 27, 2026
- Add Python 3.14 to the wheel publishing matrix (NVIDIA#750)
- feat: swap out internal device array usage with `StridedMemoryView` (NVIDIA#703)
- Fix max block size computation in `forall` (NVIDIA#744)
- Fix prologue debug line info pointing to decorator instead of def line (NVIDIA#746)
- Fix kernel return type in DISubroutineType debug metadata (NVIDIA#745)
- Fix missing line info in Jupyter notebooks (NVIDIA#742)
- Fix: Pass correct flags to linker when debugging in the presence of LTOIR code (NVIDIA#698)
- chore(deps): add cuda-pathfinder to pixi deps (NVIDIA#741)
- fix: enable flake8-bugbear lints and fix found problems (NVIDIA#708)
- fix: Fix race condition in CUDA Simulator (NVIDIA#690)
- ci: run tests in parallel (NVIDIA#740)
- feat: users can pass `shared_memory_carveout` to @cuda.jit (NVIDIA#642)
- Fix compatibility with NumPy 2.4: np.trapz and np.in1d removed (NVIDIA#739)
- Pass the -numba-debug flag to libnvvm (NVIDIA#681)
- ci: remove rapids containers from conda ci (NVIDIA#737)
- Use `pathfinder` for dynamic libraries (NVIDIA#308)
- CI: Add CUDA 13.1 testing support (NVIDIA#705)
- Adding `pixi run test` and `pixi run test-par` support (NVIDIA#724)
- Disable per-PR nvmath tests + follow same test practice (NVIDIA#723)
- chore(deps): regenerate pixi lockfile (NVIDIA#722)
- Fix DISubprogram line number to point to function definition line (NVIDIA#695)
- revert: chore(dev): build pixi using rattler (NVIDIA#713) (NVIDIA#719)
- [feat] Initial version of the Numba CUDA GDB pretty-printer (NVIDIA#692)
- chore(dev): build pixi using rattler (NVIDIA#713)
- build(deps): bump the actions-monthly group across 1 directory with 8 updates (NVIDIA#704)
@gmarkall gmarkall mentioned this pull request Jan 27, 2026
kkraus14 pushed a commit that referenced this pull request Jan 28, 2026
- Add Python 3.14 to the wheel publishing matrix (#750)
- feat: swap out internal device array usage with `StridedMemoryView`
(#703)
- Fix max block size computation in `forall` (#744)
- Fix prologue debug line info pointing to decorator instead of def line
(#746)
- Fix kernel return type in DISubroutineType debug metadata (#745)
- Fix missing line info in Jupyter notebooks (#742)
- Fix: Pass correct flags to linker when debugging in the presence of
LTOIR code (#698)
- chore(deps): add cuda-pathfinder to pixi deps (#741)
- fix: enable flake8-bugbear lints and fix found problems (#708)
- fix: Fix race condition in CUDA Simulator (#690)
- ci: run tests in parallel (#740)
- feat: users can pass `shared_memory_carveout` to @cuda.jit (#642)
- Fix compatibility with NumPy 2.4: np.trapz and np.in1d removed (#739)
- Pass the -numba-debug flag to libnvvm (#681)
- ci: remove rapids containers from conda ci (#737)
- Use `pathfinder` for dynamic libraries (#308)
- CI: Add CUDA 13.1 testing support (#705)
- Adding `pixi run test` and `pixi run test-par` support (#724)
- Disable per-PR nvmath tests + follow same test practice (#723)
- chore(deps): regenerate pixi lockfile (#722)
- Fix DISubprogram line number to point to function definition line
(#695)
- revert: chore(dev): build pixi using rattler (#713) (#719)
- [feat] Initial version of the Numba CUDA GDB pretty-printer (#692)
- chore(dev): build pixi using rattler (#713)
- build(deps): bump the actions-monthly group across 1 directory with 8
updates (#704)

<!--

Thank you for contributing to numba-cuda :)

Here are some guidelines to help the review process go smoothly.

1. Please write a description in this text box of the changes that are
being
   made.

2. Please ensure that you have written units tests for the changes
made/features
   added.

3. If you are closing an issue please use one of the automatic closing
words as
noted here:
https://help.github.com/articles/closing-issues-using-keywords/

4. If your pull request is not ready for review but you want to make use
of the
continuous integration testing facilities please label it with `[WIP]`.

5. If your pull request is ready to be reviewed without requiring
additional
work on top of it, then remove the `[WIP]` label (if present) and
replace
it with `[REVIEW]`. If assistance is required to complete the
functionality,
for example when the C/C++ code of a feature is complete but Python
bindings
are still required, then add the label `[HELP-REQ]` so that others can
triage
and assist. The additional changes then can be implemented on top of the
same PR. If the assistance is done by members of the rapidsAI team, then
no
additional actions are required by the creator of the original PR for
this,
otherwise the original author of the PR needs to give permission to the
person(s) assisting to commit to their personal fork of the project. If
that
doesn't happen then a new PR based on the code of the original PR can be
opened by the person assisting, which then will be the PR that will be
   merged.

6. Once all work has been done and review has taken place please do not
add
features or make changes out of the scope of those requested by the
reviewer
(doing this just add delays as already reviewed code ends up having to
be
re-reviewed/it is hard to tell what is new etc!). Further, please do not
rebase your branch on main/force push/rewrite history, doing any of
these
   causes the context of any comments made by reviewers to be lost. If
   conflicts occur against main they should be resolved by merging main
   into the branch used for making the pull request.

Many thanks in advance for your cooperation!

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants