[Refactor][NFC] Vendor in numba.misc for CUDA-specific changes

[VijayKandiah]

This PR vendors in the necessary submodules from numba.misc for future CUDA-specific customizations.

[copy-pr-bot]

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[VijayKandiah]

/ok to test

[gmarkall]

/ok to test

[gmarkall]

All the imports that are not at the module level seem to be missing from this file - did the formatter do something odd here? Or am I misunderstanding something?

[VijayKandiah]

The pre-commit formatter did not like three of the imports in this file as is, specifically in this code block below because they are not being used anywhere. They exist only to catch import errors but are not used anywhere, while the actual imports being used are done inside the methods _get_win_folder_with_*.

if system == "win32":
    try:
        import win32com.shell
        _get_win_folder = _get_win_folder_with_pywin32
    except ImportError:
        try:
            from ctypes import windll
            _get_win_folder = _get_win_folder_with_ctypes
        except ImportError:
            try:
                import com.sun.jna
                _get_win_folder = _get_win_folder_with_jna
            except ImportError:
                _get_win_folder = _get_win_folder_from_registry

I modified the above by lifting some imports from _get_win_folder_with_* to the above code block to get past formatter errors while maintaining the guards to catch import errors.

if system == "win32":
   try:
       from win32com.shell import shellcon, shell

       _get_win_folder = _get_win_folder_with_pywin32
   except ImportError:
       try:
           import ctypes
           from ctypes import windll

           _get_win_folder = _get_win_folder_with_ctypes
       except ImportError:
           try:
               from com.sun import jna
               from com.sun.jna.platform import win32

               _get_win_folder = _get_win_folder_with_jna
           except ImportError:
               _get_win_folder = _get_win_folder_from_registry

Please let me know if this approach makes sense and if there's any other imports that are missing that caught your eye. I do not see any other differences in imports.

[gmarkall]

That makes sense - I totally missed that modification because I'm not used to looking for imports at the bottom of the file (though I recognise this is the way the file is and always has been).

[gmarkall]

This looks good on the whole - there are a couple of issues noted on the diff.

The AppDirs issues are likely to only show up in use in installations that are a bit different to our CI, like where system-wide installs are used or running in Jupyter notebooks, so I'm cautious to avoid changing things in it without having a strong motivation to do so.

[VijayKandiah]

/ok to test

[VijayKandiah]

/ok to test

[VijayKandiah]

/ok to test

Resolved feedback.

[VijayKandiah]

/ok to test

[rparolin]

In a future PR, I think we should migrate these to unit test checks that are part of the suite.

[VijayKandiah]

/ok to test

[VijayKandiah]

/ok to test

[brandon-b-miller]

Looks like @gmarkall already gave this a once-over, so let's go ahead and merge here.