Skip to content

chore(dev): build pixi using rattler#713

Merged
cpcloud merged 3 commits intoNVIDIA:mainfrom
cpcloud:rattler-build
Jan 14, 2026
Merged

chore(dev): build pixi using rattler#713
cpcloud merged 3 commits intoNVIDIA:mainfrom
cpcloud:rattler-build

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 12, 2026 •
edited
Loading

Move pixi build to use upstream recipe. The only change here is to remove the stdlib(c) bit, because pixi fails to parse it. We may also be able to remove it upstream.

Closes #685.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 12, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 12, 2026 •
edited
Loading

Greptile Summary

This PR migrates the pixi build system from pixi-build-python to pixi-build-rattler-build, consolidating build configuration into recipe.yml. The changes include:

  • Migrated package build backend from pixi-build-python to pixi-build-rattler-build in pixi.toml:284
  • Removed inline package dependencies from pixi.toml (previously defined in [package.build-dependencies], [package.host-dependencies], and [package.run-dependencies] sections)
  • Added recipe.yml with complete build requirements, including the previously missing packaging dependency (addressed in commit f1eb7a9)
  • Added stdlib('c') in build requirements and corresponding c_stdlib build-variants for linux (sysroot) and win-64 (vs) platforms in pixi.toml:11-15
  • Added use_gitignore: true to source configuration in recipe.yml:14

The migration successfully consolidates the build recipe into a standard rattler-build format while maintaining all necessary dependencies.

Confidence Score: 5/5

  • This PR is safe to merge with no identified issues
  • The migration from pixi-build-python to pixi-build-rattler-build is straightforward and properly executed. All dependencies previously defined in pixi.toml have been correctly migrated to recipe.yml, including the packaging dependency that was noted as missing in the previous review thread. The addition of stdlib('c') and c_stdlib build-variants properly handles platform-specific C standard library requirements. The lockfile was regenerated appropriately.
  • No files require special attention

Important Files Changed

Filename Overview
recipe.yml Added stdlib('c') and packaging dependencies, plus use_gitignore: true for source configuration
pixi.toml Migrated from pixi-build-python to pixi-build-rattler-build backend, added c_stdlib build-variants for platform-specific stdlib handling

greptile-apps[bot]
greptile-apps bot reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 12, 2026

/ok to test

@cpcloud cpcloud requested a review from leofang January 12, 2026 13:54
@cpcloud cpcloud changed the title rattler build chore(dev): build pixi using rattler Jan 12, 2026
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 12, 2026

/ok to test

greptile-apps[bot]
greptile-apps bot reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

greptile-apps[bot]
greptile-apps bot reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

kkraus14
kkraus14 approved these changes Jan 12, 2026
View reviewed changes
@cpcloud cpcloud mentioned this pull request Jan 13, 2026
Open
2 tasks
greptile-apps[bot]
greptile-apps bot reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

cpcloud
cpcloud commented Jan 14, 2026
View reviewed changes
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 14, 2026

/ok to test

@cpcloud cpcloud enabled auto-merge (squash) January 14, 2026 18:31
@cpcloud cpcloud mentioned this pull request Jan 14, 2026
Open
@cpcloud cpcloud merged commit 084ff6c into NVIDIA:main Jan 14, 2026
75 of 90 checks passed
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 14, 2026

Hm, this shouldn't have gone in, tests were still failing. Reverting.

cpcloud added a commit to cpcloud/numba-cuda that referenced this pull request Jan 14, 2026
@cpcloud
revert: chore(dev): build pixi using rattler (NVIDIA#713)
976aa3e 
This reverts commit 084ff6c.
@greptile-apps greptile-apps bot mentioned this pull request Jan 14, 2026
Merged
cpcloud added a commit that referenced this pull request Jan 15, 2026
@cpcloud
revert: chore(dev): build pixi using rattler (#713) (#719)
7978fe2
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Jan 27, 2026
@gmarkall
Bump version to 0.25.0
cf01534 
- Add Python 3.14 to the wheel publishing matrix (NVIDIA#750)
- feat: swap out internal device array usage with `StridedMemoryView` (NVIDIA#703)
- Fix max block size computation in `forall` (NVIDIA#744)
- Fix prologue debug line info pointing to decorator instead of def line (NVIDIA#746)
- Fix kernel return type in DISubroutineType debug metadata (NVIDIA#745)
- Fix missing line info in Jupyter notebooks (NVIDIA#742)
- Fix: Pass correct flags to linker when debugging in the presence of LTOIR code (NVIDIA#698)
- chore(deps): add cuda-pathfinder to pixi deps (NVIDIA#741)
- fix: enable flake8-bugbear lints and fix found problems (NVIDIA#708)
- fix: Fix race condition in CUDA Simulator (NVIDIA#690)
- ci: run tests in parallel (NVIDIA#740)
- feat: users can pass `shared_memory_carveout` to @cuda.jit (NVIDIA#642)
- Fix compatibility with NumPy 2.4: np.trapz and np.in1d removed (NVIDIA#739)
- Pass the -numba-debug flag to libnvvm (NVIDIA#681)
- ci: remove rapids containers from conda ci (NVIDIA#737)
- Use `pathfinder` for dynamic libraries (NVIDIA#308)
- CI: Add CUDA 13.1 testing support (NVIDIA#705)
- Adding `pixi run test` and `pixi run test-par` support (NVIDIA#724)
- Disable per-PR nvmath tests + follow same test practice (NVIDIA#723)
- chore(deps): regenerate pixi lockfile (NVIDIA#722)
- Fix DISubprogram line number to point to function definition line (NVIDIA#695)
- revert: chore(dev): build pixi using rattler (NVIDIA#713) (NVIDIA#719)
- [feat] Initial version of the Numba CUDA GDB pretty-printer (NVIDIA#692)
- chore(dev): build pixi using rattler (NVIDIA#713)
- build(deps): bump the actions-monthly group across 1 directory with 8 updates (NVIDIA#704)
@gmarkall gmarkall mentioned this pull request Jan 27, 2026
Merged
kkraus14 pushed a commit that referenced this pull request Jan 28, 2026
@gmarkall
Bump version to 0.25.0 (#752)
bfa805a 
- Add Python 3.14 to the wheel publishing matrix (#750)
- feat: swap out internal device array usage with `StridedMemoryView`
(#703)
- Fix max block size computation in `forall` (#744)
- Fix prologue debug line info pointing to decorator instead of def line
(#746)
- Fix kernel return type in DISubroutineType debug metadata (#745)
- Fix missing line info in Jupyter notebooks (#742)
- Fix: Pass correct flags to linker when debugging in the presence of
LTOIR code (#698)
- chore(deps): add cuda-pathfinder to pixi deps (#741)
- fix: enable flake8-bugbear lints and fix found problems (#708)
- fix: Fix race condition in CUDA Simulator (#690)
- ci: run tests in parallel (#740)
- feat: users can pass `shared_memory_carveout` to @cuda.jit (#642)
- Fix compatibility with NumPy 2.4: np.trapz and np.in1d removed (#739)
- Pass the -numba-debug flag to libnvvm (#681)
- ci: remove rapids containers from conda ci (#737)
- Use `pathfinder` for dynamic libraries (#308)
- CI: Add CUDA 13.1 testing support (#705)
- Adding `pixi run test` and `pixi run test-par` support (#724)
- Disable per-PR nvmath tests + follow same test practice (#723)
- chore(deps): regenerate pixi lockfile (#722)
- Fix DISubprogram line number to point to function definition line
(#695)
- revert: chore(dev): build pixi using rattler (#713) (#719)
- [feat] Initial version of the Numba CUDA GDB pretty-printer (#692)
- chore(dev): build pixi using rattler (#713)
- build(deps): bump the actions-monthly group across 1 directory with 8
updates (#704)

<!--

Thank you for contributing to numba-cuda :)

Here are some guidelines to help the review process go smoothly.

1. Please write a description in this text box of the changes that are
being
   made.

2. Please ensure that you have written units tests for the changes
made/features
   added.

3. If you are closing an issue please use one of the automatic closing
words as
noted here:
https://help.github.com/articles/closing-issues-using-keywords/

4. If your pull request is not ready for review but you want to make use
of the
continuous integration testing facilities please label it with `[WIP]`.

5. If your pull request is ready to be reviewed without requiring
additional
work on top of it, then remove the `[WIP]` label (if present) and
replace
it with `[REVIEW]`. If assistance is required to complete the
functionality,
for example when the C/C++ code of a feature is complete but Python
bindings
are still required, then add the label `[HELP-REQ]` so that others can
triage
and assist. The additional changes then can be implemented on top of the
same PR. If the assistance is done by members of the rapidsAI team, then
no
additional actions are required by the creator of the original PR for
this,
otherwise the original author of the PR needs to give permission to the
person(s) assisting to commit to their personal fork of the project. If
that
doesn't happen then a new PR based on the code of the original PR can be
opened by the person assisting, which then will be the PR that will be
   merged.

6. Once all work has been done and review has taken place please do not
add
features or make changes out of the scope of those requested by the
reviewer
(doing this just add delays as already reviewed code ends up having to
be
re-reviewed/it is hard to tell what is new etc!). Further, please do not
rebase your branch on main/force push/rewrite history, doing any of
these
   causes the context of any comments made by reviewers to be lost. If
   conflicts occur against main they should be resolved by merging main
   into the branch used for making the pull request.

Many thanks in advance for your cooperation!

-->
@isVoid isVoid mentioned this pull request Feb 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@leofang leofang Awaiting requested review from leofang

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Review/align conda test strategy

2 participants

@cpcloud @kkraus14