Skip to content

Mark upstream umap test as flaky - #8107

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:release/26.06from
jcrist:mark-umap-test-as-flaky
May 15, 2026
Merged

Mark upstream umap test as flaky#8107
rapids-bot[bot] merged 2 commits into
NVIDIA:release/26.06from
jcrist:mark-umap-test-as-flaky

Conversation

@jcrist

@jcrist jcrist commented May 14, 2026

Copy link
Copy Markdown
Member

This fails sometimes with a trustworthiness score just below 0.85 (e.g. 0.844). This was marked as flaky before #8073 removed it, but it's still flaky so we add it back.

@jcrist jcrist self-assigned this May 14, 2026
@jcrist
jcrist requested a review from a team as a code owner May 14, 2026 19:20
@jcrist
jcrist requested a review from betatim May 14, 2026 19:20
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 14, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 14, 2026
@jcrist
jcrist requested review from csadorf and removed request for betatim May 14, 2026 19:21
@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fbf2ae39-4f14-427e-ab4f-1d0a66d8f1c2

📥 Commits

Reviewing files that changed from the base of the PR and between 5ed627f and 8120597.

📒 Files selected for processing (2)
  • python/cuml/cuml_accel_tests/upstream/umap/xfail-list.yaml
  • python/cuml/tests/test_pickle.py
✅ Files skipped from review due to trivial changes (1)
  • python/cuml/cuml_accel_tests/upstream/umap/xfail-list.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Added an entry to the intermittent/flaky test configuration to track a UMAP-related flaky case.
    • Relaxed numeric tolerance in a nearest-neighbor serialization test to reduce spurious failures and improve test stability.

Walkthrough

Adds one UMAP test selector to the flaky upstream xfail list and relaxes an absolute-tolerance in a nearest-neighbors pickle test for ivfpq/ivfflat from 1e-5 to 1e-3.

Changes

Test changes

Layer / File(s) Summary
Flaky test marker update
python/cuml/cuml_accel_tests/upstream/umap/xfail-list.yaml
Adds umap.tests.test_umap_on_iris::test_precomputed_transform_on_iris to the cuml_accel_flaky marker's tests list (under strict: false).
Nearest-neighbors pickle test tolerance
python/cuml/tests/test_pickle.py
In test_nearest_neighbors_pickle, increases np.testing.assert_allclose absolute tolerance for d1 vs d2 from 1e-5 to 1e-3 when algorithm is ivfpq or ivfflat.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

tests

Suggested reviewers

  • csadorf
  • viclafargue
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Mark upstream umap test as flaky' directly and clearly describes the main change: adding a flaky test case to the xfail-list configuration.
Description check ✅ Passed The description explains the rationale for marking the test as flaky, referencing a previous removal and the ongoing flakiness issue with the trustworthiness score.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist
jcrist changed the base branch from main to release/26.06 May 14, 2026 23:38
jcrist added 2 commits May 15, 2026 07:58
This fails sometimes with a trustworthiness score _just_ below 0.85
(e.g. 0.844).
@jcrist
jcrist force-pushed the mark-umap-test-as-flaky branch from b8ba314 to 8120597 Compare May 15, 2026 12:58
@jcrist

jcrist commented May 15, 2026

Copy link
Copy Markdown
Member Author

/merge

1 similar comment
@jcrist

jcrist commented May 15, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 75783d7 into NVIDIA:release/26.06 May 15, 2026
94 checks passed
@jcrist
jcrist deleted the mark-umap-test-as-flaky branch May 15, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants