Skip to content

Mark two tests as flaky - #7787

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
csadorf:ci/mark-calibration-tests-flaky
Feb 11, 2026
Merged

Mark two tests as flaky#7787
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
csadorf:ci/mark-calibration-tests-flaky

Conversation

@csadorf

@csadorf csadorf commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Moved from strict xfail to flaky (strict: false) in xfail-list.yaml:

  • test_calibration_multiclass[1-False-isotonic]
  • test_calibration_multiclass[1-False-sigmoid]

@csadorf
csadorf requested a review from a team as a code owner February 10, 2026 16:13
@csadorf csadorf added the bug Something isn't working label Feb 10, 2026
@csadorf
csadorf requested a review from viclafargue February 10, 2026 16:13
@csadorf csadorf added the non-breaking Non-breaking change label Feb 10, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Feb 10, 2026
@coderabbitai

coderabbitai Bot commented Feb 10, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Reorganized test configuration entries for calibration functionality to improve test management and categorization.

Walkthrough

Two xfail test entries for calibration multiclass tests are moved from their original location to a newly introduced LinearSVM block in the xfail list configuration. The block sets strict to false and groups both tests under a LinearSVM reason category.

Changes

Cohort / File(s) Summary
Test Configuration Reorganization
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-list.yaml
Moved two test_calibration_multiclass xfail entries ([1-False-isotonic] and [1-False-sigmoid]) to a new LinearSVM block with strict: false setting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

Cython / Python, improvement

Suggested reviewers

  • viclafargue
  • jcrist
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Mark two tests as flaky' accurately summarizes the main change: reclassifying two tests from strict xfail to flaky status in the xfail-list.yaml file.
Description check ✅ Passed The description clearly explains which tests were moved and why, specifying the change from strict xfail to flaky with strict: false, directly corresponding to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf

csadorf commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

@betatim Apparently I was not seeing ghosts...

@betatim

betatim commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

I restarted the failed job now that cudf fixed the bug they introduced which was causing the failure. Let's see what happens now

@dantegd

dantegd commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 9655e63 into NVIDIA:main Feb 11, 2026
171 of 173 checks passed
@csadorf
csadorf deleted the ci/mark-calibration-tests-flaky branch February 11, 2026 15:28
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 17, 2026
Moved from strict xfail to flaky (`strict: false`) in `xfail-list.yaml`:

- `test_calibration_multiclass[1-False-isotonic]`
- `test_calibration_multiclass[1-False-sigmoid]`

Authors:
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Victor Lafargue (https://github.com/viclafargue)

URL: NVIDIA#7787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants