Skip to content

Mark upstream umap test as flaky #8107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
May 15, 2026
Merged

Mark upstream umap test as flaky #8107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd845ca
Mark upstream umap test as flaky
jcrist May 14, 2026
8120597
Loosen tolerance on `test_nearest_neighbors_pickle`
jcrist May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/cuml/cuml_accel_tests/upstream/umap/xfail-list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
marker: cuml_accel_flaky
strict: false
tests:
- "umap.tests.test_umap_on_iris::test_precomputed_transform_on_iris"
- "umap.tests.test_umap_ops::test_umap_transform_embedding_stability"
- reason: UMAP using removed numpy function `in1d`
marker: cuml_accel_no_numpy_in1d
Expand Down
2 changes: 1 addition & 1 deletion python/cuml/tests/test_pickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def test_nearest_neighbors_pickle(algorithm):
# just to ensure things are wired together properly.
accuracy = (i1 == i2).sum() / i1.size
assert accuracy >= 0.9
np.testing.assert_allclose(d1, d2, atol=1e-5)
np.testing.assert_allclose(d1, d2, atol=1e-3)
else:
np.testing.assert_allclose(i1, i2)
np.testing.assert_allclose(d1, d2)
Expand Down
Loading