Support umap-learn 0.5.12 - #8073
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR raises the umap-learn upper bound to <0.5.13 across envs/configs, removes three iris xfails from the upstream xfail list, and adds runtime umap-learn version gating and a shared UMAP_NUMBA_REGRESSION condition to several tests. Changesumap-learn 0.5.13 support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
ac576a0 to
3fdc35c
Compare
The upstream regression in umap-learn with numba >= 0.62.0 that was guarded against is no longer present. Remove the xfail markers from: - test_simpl_set.py: removed numba_gte62 marker, inline xfail for test_fuzzy_simplicial_set, and unused numba/Version imports - test_umap.py: removed xfail strict markers for test_fuzzy_simplicial_set, test_umap_sigmas_rhos, and test_inverse_transform, plus unused numba/ platform/Version imports All 233 umap-related tests pass without these guards (3 were XPASS(strict) before, now 0 failures across the full test suite).
Verified each test passes 20/20 consecutive runs under cuml.accel with umap-learn 0.5.12 + numba 0.64.0. The original flakiness was introduced when the upstream test suite was added (Jul 2025, pr NVIDIA#6989) with umap-learn pinned to 0.5.7 and an older numba version. This PR's version bump to umap-learn 0.5.12 (resolving the numba >=0.62.0 regression) has fixed those issues. Tests removed from cuml_accel_flaky: - test_precomputed_transform_on_iris - test_umap_sparse_transform_on_iris - test_umap_transform_on_iris_w_pynndescent
7154b78 to
d56fe39
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/cuml/tests/test_umap_hypothesis.py`:
- Around line 979-983: The test is being broadly marked with pytest.mark.xfail
based on Version(numba.__version__) >= Version("0.62.0"); remove this broad
xfail so the test will run normally (or replace it with a narrowly-scoped
condition that only xfails reproducible failure permutations), i.e., delete or
tighten the pytest.mark.xfail decorator that references Version and
numba.__version__ (do not just set strict=False); ensure the test function using
this decorator is no longer silently suppressed so real regressions become
visible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 86a30d49-490c-4530-af2f-9c7db3309b45
📒 Files selected for processing (10)
conda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-131_arch-aarch64.yamlconda/environments/all_cuda-131_arch-x86_64.yamldependencies.yamldocs/source/supported_versions.rstpython/cuml/cuml_accel_tests/upstream/umap/xfail-list.yamlpython/cuml/pyproject.tomlpython/cuml/tests/test_simpl_set.pypython/cuml/tests/test_umap_hypothesis.py
💤 Files with no reviewable changes (1)
- python/cuml/cuml_accel_tests/upstream/umap/xfail-list.yaml
✅ Files skipped from review due to trivial changes (6)
- docs/source/supported_versions.rst
- conda/environments/all_cuda-129_arch-aarch64.yaml
- conda/environments/all_cuda-131_arch-aarch64.yaml
- python/cuml/pyproject.toml
- conda/environments/all_cuda-129_arch-x86_64.yaml
- python/cuml/tests/test_simpl_set.py
🚧 Files skipped from review as they are similar to previous changes (2)
- conda/environments/all_cuda-131_arch-x86_64.yaml
- dependencies.yaml
d56fe39 to
f76a27a
Compare
…ap-learn-0-5-12 # Conflicts: # conda/environments/all_cuda-132_arch-aarch64.yaml # conda/environments/all_cuda-132_arch-x86_64.yaml
|
/merge |
This fails sometimes with a trustworthiness score _just_ below 0.85 (e.g. 0.844). This was marked as flaky before #8073 removed it, but it's still flaky so we add it back. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Simon Adorf (https://github.com/csadorf) - Bradley Dice (https://github.com/bdice) URL: #8107
umap-learn 0.5.12 is the latest release but cuML currently caps support at
<0.5.12.Update dependency bounds and support-version docs to include 0.5.12. The upstream regression with numba >= 0.62.0 that caused test failures in older versions has been resolved, so remove the xfail markers that were guarding against it.
dependencies.yaml,pyproject.toml, both conda env files, docs: relax upper bound from<0.5.12to<0.5.13test_simpl_set.py,test_umap.py: remove numba ≥ 0.62.0 xfail strict markers (regression fixed, all 233 tests pass)xfail-list.yaml: remove three flaky tests verified passing 20/20 times under cuml.accel with this versionCloses #8070