[None][test] temporarily waive Cosmos3 B200 failures - #15195
Conversation
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
|
/bot skip --comment "Update waive" |
📝 WalkthroughWalkthroughThis pull request adds eight temporary skip waiver entries to the test list for Cosmos3 visual-generation pipeline and transformer tests on DGX_B200 hardware. The additions mark specific test cases (FP8 load and transformer checkpoint/unit tests) as ChangesCosmos3 Test Waivers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
232-232: ⚡ Quick winFile-level skip entries likely ineffective.
Lines 232 and 234 skip entire test files without the
::TestClass::test_methodnotation. Searching the existing waives file shows no other bare-filename skips—all entries use the::notation for specific tests. Since pytest generates nodeids liketest_file.py::TestClass::test_method(confirmed in code snippet 3), these file-level entries likely won't match any collected items and are ineffective.The specific test-level entries on lines 233 and 235–239 already cover the failing tests mentioned in the PR objectives. Recommend removing lines 232 and 234 unless there's evidence that file-level skips are expanded or matched by special logic.
Proposed change
-full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_pipeline.py SKIP (temporary ToT main waive; Cosmos3 config split fix pending) full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_pipeline.py::TestCosmos3FP8Load::test_fp8_load_and_t2v SKIP (temporary ToT main waive; Cosmos3 config split fix pending) -full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_transformer.py SKIP (temporary ToT main waive; Cosmos3 config split fix pending) full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_transformer.py::TestCosmos3TransformerCheckpoint::test_load_fp8_quantization[FP8] SKIP (temporary ToT main waive; Cosmos3 config split fix pending)Also applies to: 234-234
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 232, Remove the two file-level waive entries that list "full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_pipeline.py SKIP (temporary ToT main waive; Cosmos3 config split fix pending)" (the bare-filename skips) because pytest nodeids use the ::TestClass::test_method notation and the existing specific test-level entries already cover the failing tests; delete those bare file entries so only the specific test-level waives remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 232-239: The waive entries in
tests/integration/test_lists/waives.txt for Cosmos3 use inline reasons instead
of a tracking nvbugs link; create a single nvbugs tracking bug for the "Cosmos3
config split fix" and update all eight waive lines
(full:DGX_B200/unittest/_torch/visual_gen/test_cosmos33_pipeline.py and
full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_transformer.py entries
including specific tests like TestCosmos3FP8Load::test_fp8_load_and_t2v and
TestCosmos3TransformerCheckpoint::test_load_fp8_quantization[FP8] and
TestCosmos3Unit::test_model_structure/test_reset_cache/test_sanity_forward/test_sanity_forward_i2v_mask)
to append the short nvbugs URL format (e.g., SKIP (temporary ToT main waive;
https://nvbugs/XXXX)) replacing the inline text reason so all eight lines
reference the same nvbugs ID.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 232: Remove the two file-level waive entries that list
"full:DGX_B200/unittest/_torch/visual_gen/test_cosmos3_pipeline.py SKIP
(temporary ToT main waive; Cosmos3 config split fix pending)" (the bare-filename
skips) because pytest nodeids use the ::TestClass::test_method notation and the
existing specific test-level entries already cover the failing tests; delete
those bare file entries so only the specific test-level waives remain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 01eb6e48-2d8f-4d80-a2bc-72a6b4a2d299
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #53214 [ skip ] triggered by Bot. Commit: |
|
PR_Github #53214 [ skip ] completed with state |
Summary
Test Plan
Summary by CodeRabbit