[https://nvbugs/6402009][test] unwaive Qwen3-235B NVFP4 TRTLLM MoE test - #18344
Conversation
Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughRemoved the skip waiver for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change re-enables the existing Qwen3-235B NVFP4 TRTLLM MoE accuracy test without modifying production behavior; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #69868 [ run ] triggered by Bot. Commit: |
|
/bot run --extra-stage "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" Context: the un-waived test |
|
PR_Github #69873 Bot args parsing error: usage: /bot [-h] |
|
/bot run --extra-stage "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" |
|
PR_Github #69876 [ run ] triggered by Bot. Commit: |
|
PR_Github #69868 [ run ] completed with state |
|
PR_Github #69876 [ run ] completed with state
|
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
PR_Github #70214 [ run ] triggered by Bot. Commit: |
|
PR_Github #70214 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #70262 [ run ] triggered by Bot. Commit: |
|
PR_Github #70262 [ run ] completed with state |
Dev Engineer Review
NVBug 6402009waiver forTestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm].test-db/l0_gb200_multi_nodes.ymlwith a 90-minute timeout and isolation.Verdict: sufficient
QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm].tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml.tests/integration/test_lists/qa/llm_function_core.txt.Verdict: needs follow-up
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.