[https://nvbugs/6652876][fix] Fix release checks and waive Laguna XS FP8 - #18099
Conversation
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe PR removes an unused ChangesTest maintenance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes an unused test-only import and does not alter production behavior or public APIs. The PR is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
|
/bot skip --comment "Fix pre-merge and waive a test" |
|
PR_Github #68561 [ skip ] triggered by Bot. Commit: |
|
PR_Github #68561 [ skip ] completed with state |
Description
This PR addresses two CI issues:
LoraConfigimport left by the LoRA refactor. Theautoflakehook removes this import and causes release checks to fail.accuracy/test_llm_api_pytorch.py::TestLagunaXS::test_fp8only onRTXPro6000D, tracked by NVBug 6652876, due to a CUDA illegal memory access that can leave pytest hanging.The waiver is hardware-scoped, so the test remains active on other platforms. These changes have no functional or public API impact.
Test Coverage
pre-commit run autoflake --all-files --show-diff-on-failure --verbosemainto this branchtests/integration/test_lists/waives.txt, including formatting, duplicate-waive, and AST validationgit diff --checkPR Checklist
RTXPro6000Dand linked to NVBug 6652876.Dev Engineer Review
LoraConfigimport fromtests/unittest/llmapi/lora_test_utils.py.TestLagunaXS::test_fp8onRTXPro6000Dintests/integration/test_lists/waives.txt.NVBug 6652876.autoflake, pre-commit hooks, andgit diff --check.QA Engineer Review
test-db/orqa/files were modified.