Skip to content

[https://nvbugs/6652876][fix] Fix release checks and waive Laguna XS FP8 - #18099

Merged
chzblych merged 2 commits into
NVIDIA:mainfrom
chzblych:fix/release-check-unused-lora-config-import
Aug 23, 2026
Merged

[https://nvbugs/6652876][fix] Fix release checks and waive Laguna XS FP8#18099
chzblych merged 2 commits into
NVIDIA:mainfrom
chzblych:fix/release-check-unused-lora-config-import

Conversation

@chzblych

@chzblych chzblych commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR addresses two CI issues:

  • Remove an unused LoraConfig import left by the LoRA refactor. The autoflake hook removes this import and causes release checks to fail.
  • Waive accuracy/test_llm_api_pytorch.py::TestLagunaXS::test_fp8 only on RTXPro6000D, tracked by NVBug 6652876, due to a CUDA illegal memory access that can leave pytest hanging.

The waiver is hardware-scoped, so the test remains active on other platforms. These changes have no functional or public API impact.

Test Coverage

  • pre-commit run autoflake --all-files --show-diff-on-failure --verbose
  • Pre-commit hooks for the commit range from main to this branch
  • Pre-commit hooks for tests/integration/test_lists/waives.txt, including formatting, duplicate-waive, and AST validation
  • git diff --check

PR Checklist

  • PR description explains both changes and their impact.
  • Change follows the TensorRT-LLM coding guidelines.
  • The test waiver is scoped to RTXPro6000D and linked to NVBug 6652876.
  • No new code path, dependency, public API, ownership, documentation, or architecture change is introduced.
  • The applicable checklist items have been reviewed.

Dev Engineer Review

  • Removed the unused LoraConfig import from tests/unittest/llmapi/lora_test_utils.py.
  • Added a waiver for TestLagunaXS::test_fp8 on RTXPro6000D in tests/integration/test_lists/waives.txt.
  • The waiver references NVBug 6652876.
  • The changes are correctly scoped and have no public API impact.
  • Reported checks passed: autoflake, pre-commit hooks, and git diff --check.

QA Engineer Review

  • No test functions were added, modified, or removed.
  • No test-db/ or qa/ files were modified.
  • The waiver entry uses the reported test, platform, and bug reference.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych
chzblych requested a review from a team as a code owner August 23, 2026 08:28
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fcb3c1a1-2a3a-4fd9-8d1e-aaadb25961f2

📥 Commits

Reviewing files that changed from the base of the PR and between 1f1c5e3 and f444920.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The PR removes an unused LoraConfig import and adds an RTXPro6000D waiver for TestLagunaXS::test_fp8, tracked by NVBug 6652876.

Changes

Test maintenance

Layer / File(s) Summary
LoRA utility cleanup and FP8 waiver
tests/unittest/llmapi/lora_test_utils.py, tests/integration/test_lists/waives.txt
The unused LoraConfig import is removed. The LagunaXS FP8 test is skipped on RTXPro6000D and linked to NVBug 6652876.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f4449

This change removes an unused test-only import and does not alter production behavior or public APIs. The PR is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining.

Possibly related PRs

Suggested reviewers: brnguyen2, lori-ren

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title follows the required ticket-and-type format and clearly describes the CI fix and hardware-scoped FP8 waiver.
Description check ✅ Passed The description explains the issues, solutions, scope, test coverage, and checklist items with sufficient detail.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Fix pre-merge and waive a test"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68561 [ skip ] triggered by Bot. Commit: f444920 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68561 [ skip ] completed with state SUCCESS. Commit: f444920
Skipping testing for commit f444920

Link to invocation

@chzblych chzblych changed the title [None][fix] Remove unused LoRA config import [https://nvbugs/6652876][fix] Fix release checks and waive Laguna XS FP8 Aug 23, 2026
@chzblych
chzblych enabled auto-merge (squash) August 23, 2026 10:05
@chzblych
chzblych disabled auto-merge August 23, 2026 10:06
@chzblych
chzblych merged commit 11e1b99 into NVIDIA:main Aug 23, 2026
14 checks passed
@chzblych
chzblych deleted the fix/release-check-unused-lora-config-import branch August 23, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants