Skip to content

[None][ci] waive pre-existing test failures on main - #18055

Closed
brnguyen2 wants to merge 1 commit into
NVIDIA:mainfrom
brnguyen2:prbs/waives
Closed

[None][ci] waive pre-existing test failures on main#18055
brnguyen2 wants to merge 1 commit into
NVIDIA:mainfrom
brnguyen2:prbs/waives

Conversation

@brnguyen2

@brnguyen2 brnguyen2 commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Waives for pre-existing test failures on main, each with a filed tracking bug. These failures block unrelated PRs; landing the waives here keeps them out of those PRs' diffs.

Test Tracking bug Blocked PR(s)
unittest/_torch/speculative/test_eagle3.py https://nvbugs/5461761 #18033

Maintained by pr-babysitter: entries are pruned automatically as main picks their tests up, and the PR closes itself when nothing is left to carry. The branch is regenerated on each change — do not push to it.

Dev Engineer Review

  • Added waiver entries for the LagunaXS NVFP4 test, six KV-cache scheduler tests, and the Eagle3 speculative test.
  • The changes use the expected waives.txt format and link each entry to an NVBug reference.
  • The change is limited to test waivers. No public entities or APIs changed.
  • Review effort is low.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Added skip entries for the LagunaXS NVFP4 test, six KV-cache scheduler tests, and the Eagle3 speculative test.
  • No test-db or qa files were modified.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 66e50c1b-41e8-46cd-b4d8-4723d5df6a21

📥 Commits

Reviewing files that changed from the base of the PR and between 64ce60e and 79445d0.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The integration waiver list now skips the LagunaXS NVFP4 test, six KV-cache scheduler tests, and the Eagle3 speculative test module. Each entry references an NVBug.

Changes

Integration test waivers

Layer / File(s) Summary
Add tracked test waivers
tests/integration/test_lists/waives.txt
Adds NVBug-referenced skip entries for the LagunaXS NVFP4 test, six KV-cache scheduler tests, and the Eagle3 speculative test module.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to 79445

The change adds a targeted waiver for a pre-existing test failure. It is mergeable with explicit owner follow-up to confirm the affected test scope before QA review closes.

Possibly related PRs

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the repository format and clearly states that pre-existing test failures on main are waived.
Description check ✅ Passed The description explains the waiver purpose, tracking bug, blocked PR, and automatic maintenance, but omits the template's Test Coverage and checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68183 [ run ] triggered by Bot. Commit: eef4b28 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68183 [ run ] completed with state SUCCESS. Commit: eef4b28
/LLM/main/L0_MergeRequest_PR pipeline #55624 completed with status: 'SUCCESS'

CI Report

Link to invocation

…sting failures on main; tracking bugs in the PR description)

Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
@brnguyen2

Copy link
Copy Markdown
Collaborator Author

Closing: this waive doesn't hold up.

  • The tracking bug it references, https://nvbugs/5461761, is closed (fixed/verified Oct 2025) — it was picked in error by pr-babysitter's existing-bug search; that bug is now fixed so closed bugs can't be adopted.
  • The file-level SKIP of unittest/_torch/speculative/test_eagle3.py isn't justified as a pre-existing flake blocking [None][infra] Declare and pin CI-imported deps to prevent transitive drops #18033: that PR's actual CI failures are TestLagunaXS::test_nvfp4 (timeout), test_cbts_coverage_pilot, and Slurm/checkout infra — no eagle3. Over the last 14 days the file's failures are 15/1636 runs and mostly triaged as individual PRs' own assertion failures, not a main-side flake worth dropping the whole file's coverage.

No tracking bug filed. If a genuine eagle3 flake shows up later it can be waived narrowly against a fresh open bug.

@brnguyen2 brnguyen2 closed this Aug 21, 2026
@brnguyen2
brnguyen2 deleted the prbs/waives branch August 21, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants