Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 18, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test configuration to skip specific test cases related to LLM API functionality. This ensures test suite stability and focuses validation on supported configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

@jieli-matrix jieli-matrix self-assigned this Jan 19, 2026
@jieli-matrix jieli-matrix marked this pull request as ready for review January 19, 2026 10:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

This pull request adds 7 new test skip entries to the waives.txt file, marking various LLM model test configurations as SKIP with associated nvbugs references. The changes expand the list of excluded tests across multiple test modules and configurations.

Changes

Cohort / File(s) Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Added 7 SKIP entries for failing LLM integration tests across multiple model variants including DeepSeekV3Lite, Llama3.1-8B, Llama3.3-70B, and Nemotron configurations, with associated nvbugs tracking references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and vague ('waive failed cases') without following the template structure or providing details about what, why, test coverage, or checklist items. Expand the description to follow the template: explain which failed cases are being waived, why they are being skipped, provide test coverage details, and complete the PR checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding failed test cases to waives.txt, matching the changeset content exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260118_LLM_FUNCTION_TEST_1849 branch from 2ce2699 to 6548ff5 Compare January 19, 2026 10:40
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@jieli-matrix jieli-matrix enabled auto-merge (squash) January 19, 2026 10:43
@tensorrt-cicd
Copy link
Collaborator

PR_Github #32571 [ run ] triggered by Bot. Commit: 6548ff5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32571 [ run ] completed with state FAILURE. Commit: 6548ff5
/LLM/main/L0_MergeRequest_PR pipeline #25214 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260118_LLM_FUNCTION_TEST_1849 branch from 6548ff5 to de8648f Compare January 20, 2026 02:10
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32631 [ run ] triggered by Bot. Commit: de8648f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32631 [ run ] completed with state SUCCESS. Commit: de8648f
/LLM/main/L0_MergeRequest_PR pipeline #25263 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Jie Li <lijie@nvidia.com>
@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260118_LLM_FUNCTION_TEST_1849 branch from de8648f to 12f18b4 Compare January 20, 2026 03:01
@jieli-matrix
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32642 [ reuse-pipeline ] triggered by Bot. Commit: 12f18b4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32642 [ reuse-pipeline ] completed with state SUCCESS. Commit: 12f18b4
Reusing PR_Github #32631 (Partly Tested) for commit 12f18b4

@jieli-matrix jieli-matrix merged commit 26bc168 into NVIDIA:main Jan 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants