Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 25, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Expanded the test skip list to waive additional test scenarios across various model implementations.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv marked this pull request as ready for review January 26, 2026 03:04
@xinhe-nv xinhe-nv enabled auto-merge (squash) January 26, 2026 03:04
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Added seven new test skip entries to the waives list, marking various model tests (OpenAI nemotron, GPTOSS, NemotronV3Super, Qwen3, and others) as SKIP with associated nvbugs issue references. No logic or control flow modifications.

Changes

Cohort / File(s) Summary
Test Skip List Updates
tests/integration/test_lists/waives.txt
Added 7 new SKIP entries for failing tests across multiple model variants with nvbugs issue tracking links

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • StanleySun639
  • LarryXFly
  • jieli-matrix
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description 'waive failed cases.' is vague and lacks required sections from the template, including detailed explanation, test coverage details, and checklist completion. Expand the description to explain which test cases are being waived and why, document relevant test coverage, and complete the PR checklist as specified in the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Add failed cases into waives.txt' is specific and directly related to the changeset, which adds new test entries to the waives.txt skip list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33510 [ run ] triggered by Bot. Commit: ee4facf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33510 [ run ] completed with state SUCCESS. Commit: ee4facf
/LLM/main/L0_MergeRequest_PR pipeline #25858 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

Signed-off-by: xinhe-nv <[email protected]>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33523 [ reuse-pipeline ] triggered by Bot. Commit: e626c5f

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33524 [ reuse-pipeline ] triggered by Bot. Commit: e626c5f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33523 [ reuse-pipeline ] completed with state ABORTED. Commit: e626c5f
Can't reuse PR_Github #33510 (Partly Tested) with status: SUCCESS

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33524 [ reuse-pipeline ] completed with state SUCCESS. Commit: e626c5f
Reusing PR_Github #33510 (Partly Tested) for commit e626c5f

@xinhe-nv xinhe-nv merged commit 2d8245d into NVIDIA:main Jan 26, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260125_LLM_FUNCTION_CLUSTER_TEST_1245 branch January 26, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants