Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 18, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations to exclude additional test cases from automated test runs.

✏️ Tip: You can customize this high-level summary in your review settings.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260119_LLM_FUNCTION_CLUSTER_TEST_1233 branch from b9fe653 to 485f8a0 Compare January 19, 2026 09:05
@xinhe-nv xinhe-nv requested a review from jieli-matrix January 19, 2026 09:05
@xinhe-nv xinhe-nv marked this pull request as ready for review January 19, 2026 09:05
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [TRTLLM-8638][fix] Add failed cases into waives.txt Jan 19, 2026
@xinhe-nv xinhe-nv enabled auto-merge (squash) January 19, 2026 09:06
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Added eight SKIP entries to tests/integration/test_lists/waives.txt for various test cases including accuracy and language model API tests, with some duplicate entries appearing across two separate blocks in the diff.

Changes

Cohort / File(s) Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Added SKIP entries for multiple test cases (TestLlama4ScoutInstruct, TestGLM4_6, TestGPTOSS, TestGemma3_1BInstruct, TestNemotronNano, and others) with duplicate entries appearing in two separate change blocks

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required sections from the template (Description, Test Coverage, and PR Checklist), making it impossible to understand the rationale, test coverage, or verification of the changes. Expand the description with: (1) explanation of which tests failed and why they're being waived, (2) list of relevant test coverage, and (3) complete the PR Checklist items as required by the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: adding failed test cases to the waives.txt file, with appropriate JIRA ticket reference and [fix] type designation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32555 [ run ] triggered by Bot. Commit: 485f8a0

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260119_LLM_FUNCTION_CLUSTER_TEST_1233 branch from 485f8a0 to 1e5f7bb Compare January 19, 2026 10:45
@tensorrt-cicd
Copy link
Collaborator

PR_Github #32555 [ run ] completed with state SUCCESS. Commit: 485f8a0
/LLM/main/L0_MergeRequest_PR pipeline #25203 (Partly Tested) completed with status: 'SUCCESS'

…ION_CLUSTER_TEST_1233

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Collaborator Author

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32655 [ run ] triggered by Bot. Commit: c1244ee

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32655 [ run ] completed with state SUCCESS. Commit: c1244ee
/LLM/main/L0_MergeRequest_PR pipeline #25278 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32662 [ reuse-pipeline ] triggered by Bot. Commit: a46871e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32662 [ reuse-pipeline ] completed with state SUCCESS. Commit: a46871e
Reusing PR_Github #32655 (Partly Tested) for commit a46871e

@xinhe-nv xinhe-nv merged commit fc467d0 into NVIDIA:main Jan 20, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260119_LLM_FUNCTION_CLUSTER_TEST_1233 branch January 20, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants