Perf Config for 1 node GB200 DSV3 - #3545
Closed
gautham-kollu wants to merge 61 commits into
Closed
Conversation
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
gautham-kollu
marked this pull request as ready for review
April 27, 2026 22:20
Contributor
Author
|
/ok to test b55883a |
cspades
reviewed
Apr 27, 2026
cspades
left a comment
Contributor
There was a problem hiding this comment.
Already LGTM but I think you turned on an argument that isn't relevant to MFSDP.
Contributor
|
Also, let's wait until this PR merges and you can use the precision-aware optimization path: NVIDIA/Megatron-LM#4427 Loss should go down, if you can triple-check for me! |
rapatel
reviewed
Apr 27, 2026
Contributor
|
LGTM. Thanks @gautham-kollu |
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Contributor
Author
|
/ok to test 8ea7c14 |
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Contributor
Author
|
/ok to test 77cfa8c |
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Contributor
Author
|
/ok to test 0146b09 |
cspades
reviewed
Apr 28, 2026
|
|
||
| # Validate reuse_grad_buf_for_mxfp8_param_ag when FSDP is not enabled | ||
| is_fsdp = self.dist.use_megatron_fsdp or self.ddp.use_megatron_fsdp | ||
| if not is_fsdp and self.mixed_precision.fp8_param_gather and self.mixed_precision.fp8_recipe == "mxfp8": |
Contributor
There was a problem hiding this comment.
self.mixed_precision.fp8_param_gather -> self.ddp.fp8_param_gather IIRC?
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Contributor
Author
|
/ok to test eb0f20b |
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: gautham-kollu <gkollu@nvidia.com>
Contributor
Author
|
/ok to test cf09f4b |
Signed-off-by: lonexreb <reach2shubhankar@gmail.com>
…or FLOPs calculator (#3695) Signed-off-by: lonexreb <reach2shubhankar@gmail.com> Co-authored-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: lonexreb <reach2shubhankar@gmail.com> Co-authored-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: lonexreb <reach2shubhankar@gmail.com> Co-authored-by: Chen Cui <chcui@nvidia.com>
…#3743) Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com> Co-authored-by: gautham-kollu <gkollu@nvidia.com>
…#3764) Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…256x gpu scale expendable segments addition due to CUDA OOM issue (#3759) Signed-off-by: Rahul Salagame <rsalagame@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…d generation (#3758) Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Lianglipeng <lianglipeng@didiglobal.com> Signed-off-by: hbhflw2000 <417911774@qq.com> Co-authored-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Yuekai Zhang <zhangyuekai@foxmail.com> Co-authored-by: Chen Cui <chcui@nvidia.com>
…workflow (#3779) Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: gautham-kollu <gkollu@nvidia.com>
gautham-kollu
force-pushed
the
gk/1node_gb200_dsv3
branch
from
May 12, 2026 22:50
eda5670 to
d9f7c49
Compare
5 tasks
gautham-kollu
added a commit
that referenced
this pull request
May 13, 2026
Squashed version of PR #3545 — perf config for 1-node GB200 DeepSeek V3 with all perk knobs. - Add GB200 DSV3 perf functional test (L0_Launch_recipes_deepseek_perf.sh, test_deepseek_recipes_pretrain_perf.py, gb200 golden values) - Wire reuse_grad_buf_for_mxfp8_param_ag for FSDP and handle None mixed_precision case in training/config.py - Drop now-unused branch in training/mixed_precision.py - Update unit tests for the above - Extend scripts/performance argument_parser and evaluate utilities Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Contributor
Author
|
Closing this in favor of #3796 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Perf Config for 1 node GB200 DSV3 with all the perk knobs
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information