[build] chore: bump transformer-engine to release_v2.15 - #3672
Conversation
…-attn-4 extra Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 3792466 |
|
Light Code Review - Clean dependency PR. Two observations: (1) No version constraint on flash-attn-4 - the fa4 extra specifies flash-attn-4 cu13 with no version pin. Since this is a pre-1.0 beta 4.0.0b11, future uv lock runs could pull in a version with breaking API changes. Consider adding a lower bound. (2) TE override now tracks a branch instead of a SHA - release_v2.15 replaces the previous f031cf87 pin. The lockfile still pins the exact commit 3378ef15, so uv sync --locked is deterministic. On lockfile regen, the resolved commit will float to the branch tip. Neither is a blocker. Suggested test cases: No perf tests impacted. |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 24fa152 |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
test |
|
Clean dependency bump. Only pyproject.toml and uv.lock changed, lockfile delta is limited to the TE package as expected. Two observations: (1) Missing full-test-suite label - the bump-dependency skill says TE bumps are high-blast-radius and should carry full-test-suite to pull L2 into the PR run. L0+L1 green is good, but L2 coverage would be safer for a TE major-minor bump. Consider adding the label and running L2 before merge, or explicitly noting the skip rationale. (2) Branch pin vs SHA pin - the previous TE override used a full SHA (f031cf87); the new one uses a branch name (release_v2.15). The lockfile still pins the resolved commit (3378ef15), so builds from the lockfile are reproducible. However, a future uv lock will silently advance to whatever release_v2.15 points to. This is fine if intentional, just noting the style change. No code changes, no bugs to flag. Suggested test cases: No perf tests impacted. |
|
(Please ignore the two comments above — sandbox formatting issues. This is the final review.) |
|
Review: Clean dependency bump. Only pyproject.toml and uv.lock changed; lockfile delta is limited to the TE package as expected. Two observations: (1) Missing full-test-suite label — the bump-dependency skill says TE bumps are high-blast-radius and should carry full-test-suite to pull L2 (VL models, checkpoint conversion, heavy quantization) into the PR run. L0+L1 green is good, but L2 coverage would be safer for a TE major-minor bump. Consider adding the label and running L2 before merge, or explicitly noting the skip rationale. (2) Branch pin vs SHA pin — the previous TE override used a full SHA (f031cf87); the new one uses a branch name (release_v2.15). The lockfile still pins the resolved commit (3378ef15), so builds from the lockfile are reproducible, but a future uv lock will silently advance to whatever release_v2.15 points to at that time. Fine if intentional, just noting the style change. No code changes, no bugs to flag. Suggested test cases: No perf tests impacted. |
Signed-off-by: oliver könig <okoenig@nvidia.com>
…3672) Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
To be merged on 05/11
Claude summary
What
transformer-engineto track therelease_v2.15branch (currently3378ef15), replacing the prior SHA pin (f031cf87).uv.lockagainstmegatron-bridge:latest.Why
release_v2.15is the latest release branch and pulls in upstream fixes/perf since the previously pinned SHA.Lockfile delta
Usage (unchanged)
Test plan
needs-more-testsapplied to broaden coverage)Quarantined tests (this bump)
None — full L0 + L1 matrix passed first try on H100 and GB200.