[ci] fix: check-imports action lookup on ARC container runner - #3774
Conversation
The local action lookup 'uses: ./FW-CI-templates/.github/actions/check-imports' fails on the ARC container runner because the host path (/home/runner/_work/...) and the in-container path (/__w/...) diverge, so actions/checkout writes files where the action loader cannot find them. Reference the composite action directly via its source repo to skip the checkout step. Signed-off-by: oliver könig <okoenig@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ko3n1g
added
area:misc
Light ReviewLGTM. The change correctly replaces the two-step checkout + local-action pattern with a direct remote action reference, which sidesteps the container/host path divergence on ARC runners. The version pin (v0.80.1) is consistent with the existing pre-flight job reference on line 60. Minor note (non-blocking): The commented-out pip-test-pytorch job (lines 109-117) still contains the old checkout + local-action pattern at v0.39.0. If that job is ever re-enabled, it will hit the same bug. Consider updating or removing the stale commented block in a follow-up. Suggested test cases: No perf tests impacted. |
Signed-off-by: oliver könig <okoenig@nvidia.com>
…-NeMo#3774) Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
2 participants
Claude summary
What
Replaces the explicit
actions/checkout+ local-actionuses: ./...pattern with a direct remote reference to thecheck-importscomposite action.Why
On the ARC self-hosted container runner, the in-container workspace path (
/__w/Megatron-Bridge/Megatron-Bridge) and the host workspace path (/home/runner/_work/Megatron-Bridge/Megatron-Bridge) diverge.actions/checkoutruns in-container and writesFW-CI-templates/to the container path, but the GitHub Actions local-action loader resolvesuses: ./...against the host path, so it cannot findaction.yml:This failure reproduces across PRs (3772, 3545, …) — i.e. the workflow on
mainitself is broken.Because
check-importsis a composite action hosted in a public repo, referencing it viaNVIDIA-NeMo/FW-CI-templates/.github/actions/check-imports@v0.80.1sidesteps the checkout entirely — the runner fetches and caches the action via its standard remote-action path, which works regardless of container/host path mapping.