Malay/move expandable flag - #3781
Conversation
Signed-off-by: Malay Nagda <malayn@nvidia.com>
|
Light Code Review This PR promotes PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True and NCCL_GRAPH_REGISTER=0 from per-model conditionals into the global PERF_ENV_VARS default dict, then removes the now-redundant model-specific blocks. This is a good simplification. Observations
Suggested test cases No perf config files were changed, so no specific perf test names are impacted. However, since the env var change affects all perf runs globally, the following should be verified:
Generated with Claude Code |
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: Malay Nagda <malayn@nvidia.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
What does this PR do ?
Add
expandable_segmentsflag for all perf jobs except for those usingFSDPandnccl_ub.Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information