Psd/develop into master#6
Merged
Merged
Conversation
Remove @climbfuji from CODEOWNERS for psd/develop branch
Pegion updates
Merge Psd/develop to my fork
Decomp work
Merge master into develop
commits to Psd/develop
climbfuji
approved these changes
Dec 6, 2019
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I assume the changes from do_sppt to Model%do_sppt will be accompanied by changes in fv3atm to implement the logic we have been discussing a few weeks back? Otherwise I do not understand the code well enough to say anything about the changes. As long as they compile and run that's fine. Does this change the answer of the fv3_stochy/fv3_ccpp_stochy regression tests?
Collaborator
Author
|
Hi Dom,
This pull request has nothing to do with the do_sppt logic, I'm
deferring that to later. Also, I did not intend to ask you to be a
reviewer, i think it just defaulted that way.
Good point on the regression tests, I did fv3_stochy, but not
fv3_ccpp_stochy (it does not change the answer in the former). I will run
the fv3_ccpp_stochy tests now.
Thanks,
Phil
…On Fri, Dec 6, 2019 at 12:58 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** approved this pull request.
I assume the changes from do_sppt to Model%do_sppt will be accompanied by
changes in fv3atm to implement the logic we have been discussing a few
weeks back? Otherwise I do not understand the code well enough to say
anything about the changes. As long as they compile and run that's fine.
Does this change the answer of the fv3_stochy/fv3_ccpp_stochy regression
tests?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJIRVJDULYS74OHHVVRAU4DQXKVH7ANCNFSM4JW57LPQ>
.
--
Philip Pegion
NOAA/ESRL/PSD-CIRES
(303) 497-7897
philip.pegion@noaa.gov
|
climbfuji
reviewed
Dec 6, 2019
pjpegion
commented
Dec 6, 2019
Collaborator
Author
pjpegion
left a comment
pjpegion
left a comment
There was a problem hiding this comment.
i just tested fv3_ccpp_stochy, and the regression test passed.
bingfu-NOAA
approved these changes
Dec 10, 2019
pjpegion
commented
Dec 10, 2019
Collaborator
Author
pjpegion
left a comment
pjpegion
left a comment
There was a problem hiding this comment.
code is ready to merge
climbfuji
pushed a commit
to climbfuji/stochastic_physics
that referenced
this pull request
Jun 23, 2021
…OAA-PSL#6 from SamuelTrahanNOAA Add an alternative cellular automata wrapper for chemical emissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in sumfln_stochy.F90 which now allows for a lower resolution random pattern to be generated. It also fixed the lenthscale bug by setting new_lscale.true.
In addition, ntrunc and lon_s,lat_s, are no longer required (which I recommend letting the model figure out the correct pattern resolution). Bing Fu's addition of having the random pattern write out during the restart interval instead of once has been included.