Skip to content

Remove TRANSITION mode#2

Merged
pjpegion merged 1 commit into
NOAA-PSL:masterfrom
climbfuji:remove_transition_mode
Sep 23, 2019
Merged

Remove TRANSITION mode#2
pjpegion merged 1 commit into
NOAA-PSL:masterfrom
climbfuji:remove_transition_mode

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Sep 20, 2019

Changes:

  • remove all code related to the deprecated TRANSITION mode for Theia+Intel15, affects stochy_patterngenerator.F90 only

For regression testing, see NCAR/NEMSfv3gfs#251

@climbfuji climbfuji marked this pull request as ready for review September 22, 2019 14:05
@climbfuji climbfuji requested a review from pjpegion as a code owner September 22, 2019 14:05
@climbfuji
Copy link
Copy Markdown
Collaborator Author

@pjpegion this can be merged anytime, preferably before https://github.com/NCAR/NEMSfv3gfs/pull/251 is merged so that the follow-up submodule pointer update points to the latest version.

Copy link
Copy Markdown
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pjpegion
Copy link
Copy Markdown
Collaborator

Dom, Looks good. I will do the merge.

@pjpegion pjpegion merged commit 25c3321 into NOAA-PSL:master Sep 23, 2019
@climbfuji
Copy link
Copy Markdown
Collaborator Author

Thanks @pjpegion that was quick!

pjpegion added a commit that referenced this pull request Dec 6, 2019
DomHeinzeller referenced this pull request in NOAA-GSL/stochastic_physics Jan 9, 2021
climbfuji pushed a commit to climbfuji/stochastic_physics that referenced this pull request Jan 20, 2021
Add roughness length over land to the perturbed variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants