Fix non-existent include directory warning with GNU compiler#3
Merged
pjpegion merged 1 commit intoNov 20, 2019
Merged
Conversation
Collaborator
|
Change looks good, and passes regression test on hera. |
pjpegion
approved these changes
Nov 20, 2019
Collaborator
pjpegion
left a comment
pjpegion
left a comment
There was a problem hiding this comment.
Change looks good, and regression test passes on hera.
Collaborator
Author
|
This change was okayed by Dusan, we can do the merge. |
Collaborator
|
Merge is complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove ./include from list of include directories in top-level makefile to fix non-existent include directory warning with GNU compiler.
This PR is tested together with a set of PRs targeted at the dtc/develop branches in the NCAR GitHub, see NCAR/ufs-weather-model#3.
Merging this PR into the master branch requires the ok from/coordination with @junwang-noaa and @DusanJovic-NOAA, too. I think it is safe to merge, because this directory ./include inside stochastic_physics is never created.