Skip to content

Update of subgrid-scale cloud physics for MYNN/GF#3

Closed
climbfuji wants to merge 2 commits into
NOAA-GSL:gsd/developfrom
climbfuji:haiqinli_20191212_update_from_gsd_develop
Closed

Update of subgrid-scale cloud physics for MYNN/GF#3
climbfuji wants to merge 2 commits into
NOAA-GSL:gsd/developfrom
climbfuji:haiqinli_20191212_update_from_gsd_develop

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Dec 13, 2019 •
edited
Loading

This PR updates the suite definition files with the new name of the subgrid-scale cloud scheme for MYNN/GF (changed from mynnrad_{pre,post} to sgscloudrad_{pre,post}) and adds a new variable qci_conv for GSDCHEM to GFS_typedefs.{F90,meta}.

Associated PRs:
NOAA-GSL/ccpp-physics#2
#3
NOAA-GSL/ufs-weather-model#2

For regression testing, see below.

@climbfuji climbfuji mentioned this pull request Dec 13, 2019
Closed
@climbfuji
Upate of suite definition files with change of module names mynnrad_{…
408a254 
…pre,post} to sgscloudrad_{pre,post}, addition of new variable qci_conv for GSDCHEM to GFS_typedefs.{F90,meta}
@climbfuji climbfuji force-pushed the haiqinli_20191212_update_from_gsd_develop branch from 9833ee5 to 408a254 Compare December 13, 2019 22:15
@climbfuji climbfuji mentioned this pull request Dec 13, 2019
Closed
@climbfuji climbfuji marked this pull request as ready for review December 13, 2019 22:21
@DomHeinzeller
Copy link
Copy Markdown

DomHeinzeller commented Dec 13, 2019

@haiqinli @joeolson42 @tanyasmirnova please review this PR and post your comment here (I cannot add you as official reviewers). Thanks.

haiqinli
haiqinli approved these changes Dec 13, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@haiqinli haiqinli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks.

@tanyasmirnova
Copy link
Copy Markdown

tanyasmirnova commented Dec 13, 2019

Dom,
My comment is on NOAA-GSL/ccpp-physics#2 PR.
I can't approve until I hear from Haiqin and Joe.
Thanks,
Tanya

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Dec 14, 2019

Testing on macOS: The code as of Dec 13, 2019 5pm MT gives b4b identical results between IPD, CCPP dynamic and CCPP static for the fv3_gfdlmp/fv3_ccpp_gfdlmp regression tests with 32bit dynamics. The code also gives b4b identical results for CCP dynamic and CCPP static for the fv3_ccpp_gsd regression test with 64bit dynamics.

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Dec 14, 2019

Regression testing on hera/intel against official EMC baseline (trunk-20191121): the following tests did not pass, all others pass. This is OK, because these tests have been changed/added by DTC and merged into gsd/develop, but not yet into EMC's code.

rt_55_fv3_gfdlmprad_repro
rt_81_fv3_ccpp_gfdlmprad_repro
rt_101_fv3_ccpp_gsd_repro
rt_113_fv3_ccpp_gfdlmprad_prod
rt_114_fv3_ccpp_wrtGauss_nemsio_c768_prod
rt_135_fv3_ccpp_gsd_prod

DomHeinzeller
DomHeinzeller suggested changes Dec 15, 2019
View reviewed changes
Copy link
Copy Markdown

@DomHeinzeller DomHeinzeller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cannot be merged, the fv3_ccpp_gsd_warmstart regression tests (part of rt_ccpp_gsd.conf) fail:

On hera/intel, using rt_ccpp_gsd.conf (first create, then verify): fv3_ccpp_gsd_warmstart fails.

rt_ccpp_gsd_create.log
rt_ccpp_gsd_verify.log

@DomHeinzeller DomHeinzeller added do not merge Something is wrong, do not merge work in progress Still being worked on labels Dec 15, 2019
@DomHeinzeller
Copy link
Copy Markdown

DomHeinzeller commented Dec 15, 2019

Regression testing on hera/intel using rt_ccpp_dtc.conf (first create, then verify): all pass.

rt_ccpp_dtc_create.log
rt_ccpp_dtc_verify.log

@climbfuji climbfuji force-pushed the haiqinli_20191212_update_from_gsd_develop branch from 43a8e20 to b5763cc Compare December 19, 2019 04:00
@DomHeinzeller DomHeinzeller removed do not merge Something is wrong, do not merge work in progress Still being worked on labels Dec 20, 2019
@DomHeinzeller DomHeinzeller added the do not merge Something is wrong, do not merge label Dec 20, 2019
@DomHeinzeller
Copy link
Copy Markdown

DomHeinzeller commented Mar 13, 2020

@haiqinli @tanyasmirnova @joeolson42 @hannahcbarnes I believe this PR has been superseded by #13 which I just merged? Please confirm. Thanks!

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Mar 13, 2020

Superseded by #13.

@climbfuji climbfuji closed this Mar 13, 2020
DomHeinzeller pushed a commit that referenced this pull request Aug 23, 2021
@tanyasmirnova
Merge pull request #3 from climbfuji/tanya_gsl_dev_11aug21_lake_dom
fcc7a86 
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haiqinli haiqinli haiqinli approved these changes

+1 more reviewer

@DomHeinzeller DomHeinzeller DomHeinzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do not merge Something is wrong, do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@climbfuji @DomHeinzeller @tanyasmirnova @haiqinli