Update of subgrid-scale cloud physics for MYNN/GF#2
Closed
climbfuji wants to merge 3 commits into
Closed
Conversation
This was referenced Dec 13, 2019
DomHeinzeller
added
do not merge
DomHeinzeller
suggested changes
Dec 15, 2019
DomHeinzeller
left a comment
DomHeinzeller
left a comment
There was a problem hiding this comment.
This PR cannot be merged (see NOAA-GSL/fv3atm#3 for details).
DomHeinzeller
approved these changes
Dec 20, 2019
DomHeinzeller
removed
do not merge
|
@tanyasmirnova @haiqinli Per request from @joeolson42 I put these PRs on hold. Please base your work on the latest gsd/develop and pull changes from these PRs in as needed so that I do not have to replicate the work done thus far. Thank you! |
|
@haiqinli @tanyasmirnova @joeolson42 @hannahcbarnes I believe this PR has been superseded by #11 which I just merged? Please confirm. Thanks! |
Author
|
Superseded by #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the submodule pointer for FV3 for the code changes described in NOAA-GSL/fv3atm#3 and NOAA-GSL/ccpp-physics#2. It also reverts a DTC-specific change to
tests/rt.sh(location of regression test baseline).Associated PRs:
NOAA-GSL/ccpp-physics#2
NOAA-GSL/fv3atm#3
#2
See NOAA-GSL/fv3atm#3 for regression testing information.