Update of subgrid-scale cloud physics for MYNN/GF by climbfuji · Pull Request #2 · NOAA-GSL/ccpp-physics

climbfuji · 2019-12-12T20:59:16Z

This PR updates the subgrid-scale cloud calculation for MYNN/GF and renames the modules from mynnrad_{pre,post} to sgscloud_rad{pre,post} for future use by other physics schemes than MYNN. The PR also adds a new variable required for GSDCHEM coupling, qci_conv to the subgrid-scale cloud calculation and the Grell-Freitas deep convection scheme.

Associated PRs:
#2
NOAA-GSL/fv3atm#3
NOAA-GSL/ufs-weather-model#2

For regression testing, see NOAA-GSL/fv3atm#3.

…into HEAD

climbfuji · 2019-12-12T22:14:28Z

@haiqinli I created a placeholder for the proposed changes (your original PR climbfuji#2 update to the head of gsd/develop and pointing to gsd/develop's new home on the NOAA-GSD GitHub page). This PR must be accompanied by changes in fv3atm (at least the suite definition files and the CCPP prebuild config because of the change of the scheme names from MYNNrad_pre to SGSCloud_RadPre, same for post). Does this PR exist somewhere?

haiqinli · 2019-12-12T22:24:23Z

@climbfuji I just modified the SDF and prebuild config in my local copy, and have not created this PR. Do you want me to create a PR for this?

climbfuji · 2019-12-12T22:29:04Z

@climbfuji I just modified the SDF and prebuild config in my local copy, and have not created this PR. Do you want me to create a PR for this?

In this case it is ok if you give me access to the files you have changed, and I will create the FV3 PR. Thanks!

haiqinli · 2019-12-12T22:30:57Z

@climbfuji I will send you the path of these files on Hera when Hera is back. Thanks.

haiqinli · 2019-12-13T16:05:54Z

@climbfuji The CCPP prebuild config file is /scratch2/BMC/gsd-fv3-dev/Haiqin.Li/gsd-ccpp_heraT/sorc/fv3gfs_ccpp.fd/ccpp/config/ccpp_prebuild_config.py. The SDFs are at /scratch2/BMC/gsd-fv3-dev/Haiqin.Li/gsd-ccpp_heraT/sorc/fv3gfs_ccpp.fd/ccpp/suites. Thanks a lot.

climbfuji · 2019-12-13T17:20:40Z

@climbfuji The CCPP prebuild config file is /scratch2/BMC/gsd-fv3-dev/Haiqin.Li/gsd-ccpp_heraT/sorc/fv3gfs_ccpp.fd/ccpp/config/ccpp_prebuild_config.py. The SDFs are at /scratch2/BMC/gsd-fv3-dev/Haiqin.Li/gsd-ccpp_heraT/sorc/fv3gfs_ccpp.fd/ccpp/suites. Thanks a lot.

Thanks. Can you please let me know which of the suite definition files you changed? All of them are different from what it is gsd/develop today, because your code base is far behind. Thanks!

haiqinli · 2019-12-13T17:25:01Z

@climbfuji The followings SDFs are changed. Thanks.
suite_FV3_GFS_v15_gf_mynn.xml: sgscloud_radpre
suite_FV3_GFS_v15_mynn.xml: sgscloud_radpre
suite_FV3_GFS_v15_thompson_mynn.xml: sgscloud_radpre
suite_FV3_GSD_noah.xml: sgscloud_radpre
suite_FV3_GSD_v0_nothmp.xml: sgscloud_radpre
suite_FV3_GSD_v0_satadj.xml: sgscloud_radpre
suite_FV3_GSD_v0.xml: sgscloud_radpre

climbfuji · 2019-12-13T18:52:36Z

@climbfuji The followings SDFs are changed. Thanks.
suite_FV3_GFS_v15_gf_mynn.xml: sgscloud_radpre
suite_FV3_GFS_v15_mynn.xml: sgscloud_radpre
suite_FV3_GFS_v15_thompson_mynn.xml: sgscloud_radpre
suite_FV3_GSD_noah.xml: sgscloud_radpre
suite_FV3_GSD_v0_nothmp.xml: sgscloud_radpre
suite_FV3_GSD_v0_satadj.xml: sgscloud_radpre
suite_FV3_GSD_v0.xml: sgscloud_radpre

Some of these don't exist in the current gsd/develop code. I updated the following SDFs:

suite_FV3_GFS_v15_mynn.xml
suite_FV3_GFS_v15_thompson_mynn.xml
suite_FV3_GSD_noah.xml
suite_FV3_GSD_v0.xml
suite_FV3_GSD_SAR.xml
suite_FV3_GSD_v0_drag_suite.xml

Basically, I replaced mynn_rad{pre,post} with sgscloud_rad{pre,post} in all SDFs.

haiqinli · 2019-12-13T18:59:18Z

@climbfuji Great! Thanks.

climbfuji · 2019-12-13T20:48:56Z

@haiqinli I seem to be missing some changes in your fv3atm repository. ccpp_prebuild.py fails with the error message

ERROR: Variable convective_cloud_condesate_after_rainout requested by MODULE_sgscloud_radpre SCHEME_sgscloud_radpre SUBROUTINE_sgscloud_radpre_run & MODULE_cu_gf_driver SCHEME_cu_gf_driver SUBROUTINE_cu_gf_driver_run not provided by the model

Can you please provide the missing updates to GFS_typedefs.* (and others if you have - I don't think so)? Thanks.

haiqinli · 2019-12-13T20:54:35Z

@climbfuji I am sorry that I forgot to commit this change. Yes, only the update of qci_conv. It is in /scratch2/BMC/gsd-fv3-dev/Haiqin.Li/gsd-ccpp_heraT/sorc/fv3gfs_ccpp.fd/FV3/gfsphysics/GFS_layer/GFS_typedefs.F90 (meta).

climbfuji · 2019-12-13T21:13:57Z

Thanks. I will make slight changes (only allocate the array when GF deep convection is used and modify the variable declaration in sgscloud_radpre accordingly.

…f instead of hardcoded value 3

…an optional argument for progcld5, because it may not be allocated

DomHeinzeller · 2019-12-13T22:22:59Z

@haiqinli @joeolson42 @tanyasmirnova please review this PR and post your comment here (I cannot add you as official reviewers). Thanks.

haiqinli

It looks good to me. Thanks.

…reitas convection scheme is used

climbfuji · 2019-12-20T00:21:34Z

At last! Regression testing on hera/intel using rt_ccpp_gsd.conf after all changes succeeded (first create, then verify): all tests pass, including the warmstart test.

rt_ccpp_gsd_create.log
rt_ccpp_gsd_verify.log

climbfuji · 2019-12-20T00:22:31Z

@tanyasmirnova @haiqinli @joeolson42 can you please confirm and approve that this version is good to merge? Thank you!

DomHeinzeller · 2020-02-11T18:33:42Z

Superseded by #12

updating fork

CHSP latlon post: add missing code updates to CCPP

updating fork

Increase length of message and update declaration in qcmxmn to avoid writing out of bounds

update from NCAR's master

…s_20200619 Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19

CCPPv5.0.0 scientific doc sync

merge NCAR/ccpp-physics/master

…Aerosols_dom_20210823_2 Hannah gf radiation update revert aerosols dom 20210823 part 2

…210729 Update "constant" branch with latest changes in authoritative repositories

…te_from_main_20211122 New Thompson cloud fraction update from main 2021/11/22

Cloud cover xr dom

edit module_mp_thompson.F90 to remove optional keyword for rand_pert …

Minor changes to prepare for merge

Coupling Merra2 aerosol climatology and GOCART forecasted aerosol with Thompson microphysics

move setting of flag from run to init phase

…w_fix Fix to canopy arrays definitions: add intent

haiqinli and others added 8 commits September 27, 2019 18:04

"to include GF updates in GSDv0beta4"

14c1c5b

"update input of imfdeepcnv following Dom's suggestions"

4ca463c

"clean the code"

a59d416

"update to pass ccpp_gsd regression test"

0711b82

"update to pass the ccpp_gsd_noah_repro regression test case"

3a28055

"update with convective cloud & recompute cloud fraction"

03f7cc0

Merge branch 'gsd/develop' of https://github.com/noaa-gsd/ccpp-physics …

296cc94

…into HEAD

Bugfix following merge of gsd/develop into @haiqinli's code

dadee7a

Update of physics/module_SGSCloud_RadPre.{F90,meta}: use imfdeepcnv_g…

b6fc080

…f instead of hardcoded value 3

climbfuji mentioned this pull request Dec 13, 2019

Gsd/develop hli climbfuji/ccpp-physics#2

Closed

climbfuji changed the title ~~Haiqinli 20191212 update from gsd develop PLACEHOLDER~~ Update of subgrid-scale cloud physics for MYNN/GF Dec 13, 2019

climbfuji mentioned this pull request Dec 13, 2019

Update of subgrid-scale cloud physics for MYNN/GF NOAA-GSL/fv3atm#3

Closed

physics/GFS_rrtmg_pre.F90, physics/radiation_clouds.f: make qci_conv …

0f81034

…an optional argument for progcld5, because it may not be allocated

climbfuji mentioned this pull request Dec 13, 2019

Update of subgrid-scale cloud physics for MYNN/GF NOAA-GSL/ufs-weather-model#2

Closed

climbfuji marked this pull request as ready for review December 13, 2019 22:21

climbfuji requested a review from DomHeinzeller as a code owner December 13, 2019 22:21

haiqinli approved these changes Dec 13, 2019

View reviewed changes

physics/module_SGSCloud_RadPre.*: add logic for qci_conv when Grell-F…

7289051

…reitas convection scheme is used

climbfuji force-pushed the haiqinli_20191212_update_from_gsd_develop branch from d1349cd to 7289051 Compare December 19, 2019 03:59

DomHeinzeller approved these changes Dec 20, 2019

View reviewed changes

DomHeinzeller removed do not merge Something is wrong, do not merge work in progress Still being worked on labels Dec 20, 2019

haiqinli approved these changes Dec 20, 2019

View reviewed changes

DomHeinzeller added the do not merge Something is wrong, do not merge label Dec 20, 2019

DomHeinzeller closed this Feb 11, 2020

DomHeinzeller pushed a commit that referenced this pull request Apr 29, 2020

Merge pull request #2 from NOAA-GSD/gsd/develop

344c852

updating fork

DomHeinzeller pushed a commit that referenced this pull request May 20, 2020

Merge pull request #2 from climbfuji/chsp_latlon_post_dom_ccpp_mods

a757ef7

CHSP latlon post: add missing code updates to CCPP

DomHeinzeller pushed a commit that referenced this pull request Jun 19, 2020

Merge pull request #2 from NOAA-GSD/gsd/develop

008cf1a

updating fork

DomHeinzeller pushed a commit that referenced this pull request Sep 3, 2020

Merge pull request #2 from climbfuji/gcycle_tanya_update_from_dom_2

32ffcfb

Increase length of message and update declaration in qcmxmn to avoid writing out of bounds

DomHeinzeller pushed a commit that referenced this pull request Apr 1, 2021

Merge pull request #2 from NCAR/master

f2a8df4

update from NCAR's master

DomHeinzeller pushed a commit that referenced this pull request May 21, 2021

Merge pull request #2 from climbfuji/update_hafs_from_dtc_hwrf_physic…

c13b36d

…s_20200619 Update support/HAFS from NCAR dtc/hwrf-physics 2020/06/19

DomHeinzeller pushed a commit that referenced this pull request May 21, 2021

Merge pull request #2 from mzhangw/scidocv5_sync

87528e1

CCPPv5.0.0 scientific doc sync

christinaholtNOAA pushed a commit that referenced this pull request May 25, 2021

Merge pull request #2 from NCAR/master

59bba9f

merge NCAR/ccpp-physics/master

DomHeinzeller pushed a commit that referenced this pull request Aug 24, 2021

Merge pull request #2 from climbfuji/hannah_GF_RadiationUpdate_Revert…

5a7d775

…Aerosols_dom_20210823_2 Hannah gf radiation update revert aerosols dom 20210823 part 2

DomHeinzeller pushed a commit that referenced this pull request Aug 26, 2021

Merge pull request #2 from climbfuji/constant_xia_update_from_main_20…

859e48e

…210729 Update "constant" branch with latest changes in authoritative repositories

DomHeinzeller pushed a commit that referenced this pull request Dec 15, 2021

Merge pull request #2 from climbfuji/new_thompson_cloud_fraction_upda…

24d850d

…te_from_main_20211122 New Thompson cloud fraction update from main 2021/11/22

SamuelTrahanNOAA pushed a commit that referenced this pull request Mar 8, 2022

Merge pull request #2 from climbfuji/cloud_cover_xr_dom

890df49

Cloud cover xr dom

SamuelTrahanNOAA pushed a commit that referenced this pull request Mar 8, 2022

Merge pull request #2 from grantfirl/feature/stoch_spp_gjf

1e02fc8

edit module_mp_thompson.F90 to remove optional keyword for rand_pert …

mdtoyNOAA pushed a commit to mdtoyNOAA/ccpp-physics that referenced this pull request Mar 11, 2022

Merge pull request NOAA-GSL#2 from grantfirl/feature/nsslmicro_gjf

a2a7f8b

Minor changes to prepare for merge

climbfuji deleted the haiqinli_20191212_update_from_gsd_develop branch June 27, 2022 03:16

christinaholtNOAA pushed a commit that referenced this pull request Mar 2, 2023

Merge pull request #2 from ChunxiZhang-NOAA/feature/merra2_thompson

9c1943c

Coupling Merra2 aerosol climatology and GOCART forecasted aerosol with Thompson microphysics

zhanglikate referenced this pull request in zhanglikate/ccpp-physics Mar 1, 2024

Merge pull request NCAR#2 from dustinswales/move_stmt_to_init

791c6d6

move setting of flag from run to init phase

mdtoyNOAA pushed a commit to mdtoyNOAA/ccpp-physics that referenced this pull request Aug 27, 2025

code clean up NOAA-GSL#2

b2d5032

mdtoyNOAA pushed a commit to mdtoyNOAA/ccpp-physics that referenced this pull request Aug 27, 2025

Merge pull request NOAA-GSL#2 from noaa-oar-arl/feature/aqm_canopy_ne…

336447d

…w_fix Fix to canopy arrays definitions: add intent

Conversation

climbfuji commented Dec 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

climbfuji commented Dec 12, 2019

Uh oh!

haiqinli commented Dec 12, 2019

Uh oh!

climbfuji commented Dec 12, 2019

Uh oh!

haiqinli commented Dec 12, 2019

Uh oh!

haiqinli commented Dec 13, 2019

Uh oh!

climbfuji commented Dec 13, 2019

Uh oh!

haiqinli commented Dec 13, 2019

Uh oh!

climbfuji commented Dec 13, 2019

Uh oh!

haiqinli commented Dec 13, 2019

Uh oh!

climbfuji commented Dec 13, 2019

Uh oh!

haiqinli commented Dec 13, 2019

Uh oh!

climbfuji commented Dec 13, 2019

Uh oh!

DomHeinzeller commented Dec 13, 2019

Uh oh!

haiqinli left a comment

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Dec 20, 2019

Uh oh!

climbfuji commented Dec 20, 2019

Uh oh!

DomHeinzeller commented Feb 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

climbfuji commented Dec 12, 2019 •

edited

Loading