Bug fixes for/update of "Changes in cloud/radiation interaction in GSD physics suite", bug fixes for non-aerosol-aware Thompson MP#13
Merged
DomHeinzeller merged 10 commits intoMar 13, 2020
Conversation
SGSCloud_RadPre, and then rrtmg_pre. Use SGSCloud_RadPre in GSD_noah and GSD_v0 suites to replace MYNNrad_pre.
…cloud_rad{pre,post} in suites; adjust number of tracers in array of vertically diffused tracers for Thompson MP
This was referenced Feb 21, 2020
DomHeinzeller
approved these changes
Mar 13, 2020
zhanglikate
referenced
this pull request
in zhanglikate/ufsatm
Oct 7, 2025
fv3atm github issue NOAA-EMC#13: change ifmin to zero at fh00 for inline post
zhanglikate
referenced
this pull request
in zhanglikate/ufsatm
Oct 7, 2025
* Remove FMS git submodule * Update module files and top-level CMakeLists.txt to use fms module (library) built by hpc-stack. * Update ci for fms library NOAA-EMC#575 (NOAA-EMC#13) Co-authored-by: Minsuk Ji <57227195+MinsukJi-NOAA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
mynnrad_{pre,post}withsgscloud_{pre,post}in all suites that use it, removemynnrad_{pre,post}from CCPP prebuild configAssociated PRs:
NOAA-GSL/ccpp-physics#16
#13
NOAA-GSL/ufs-weather-model#11
See NOAA-GSL/ufs-weather-model#11 for regression testing information.