Skip to content

Removing ndsl.Namelist from PySHiELD#68

Merged
jjuyeonkim merged 4 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251021_remove_ndsl_namelist
Oct 27, 2025
Merged

Removing ndsl.Namelist from PySHiELD#68
jjuyeonkim merged 4 commits into
NOAA-GFDL:developfrom
jjuyeonkim:20251021_remove_ndsl_namelist

Conversation

@jjuyeonkim
Copy link
Copy Markdown
Collaborator

@jjuyeonkim jjuyeonkim commented Oct 21, 2025

Description
This follows from PyFV3 PR #88 and NDSL PR #246. It is part of NDSL Issue # 64.

This PR attempts to remove ndsl.Namelist from PySHiELD by doing the following:

  • ModifiesPhysicsConfig.from_f90nml() to use only f90nml.Namelist via NDSL helper functions
  • Removes PhysicsConfig.from_namelist()
  • Modifies the translate tests to shed its reliance on ndsl.Namelist in favor the PhysicsConfig
  • Adds --no_legacy_namelist to the github workflow translate.yaml

Partial work on NDSL Issue # 64

How Has This Been Tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules - There is a related Pace PR #153 that needs to be checked in first for the pace tests to pass.
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

Adding --no_legacy_namelist to translate.yaml
fmalatino
fmalatino previously approved these changes Oct 22, 2025
romanc
romanc previously approved these changes Oct 23, 2025
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in my eyes. I left three optional comments inline.

Comment thread pyshield/_config.py Outdated
Comment thread tests/savepoint/translate/translate_fv_update_phys.py
Comment thread tests/savepoint/translate/translate_gfs_physics_driver.py Outdated
@jjuyeonkim jjuyeonkim dismissed stale reviews from romanc and fmalatino via 6846d62 October 27, 2025 16:55
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jjuyeonkim jjuyeonkim added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NOAA-GFDL:develop with commit d2f4fb1 Oct 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants