Skip to content

Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88] #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjuyeonkim merged 3 commits into from
Oct 21, 2025
Merged

Temporary Dycore dacite Config + Dycore Config Type Check Tweak [see: PyFV3 PR #88] #152

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f52cefe
Tmp dycore dacite config related to PyFV3 PR #88 + NDSL Issue #64
jjuyeonkim Oct 15, 2025
1b958b5
Merge branch 'develop' into 20251015_dycore_dacite_config
FlorianDeconinck Oct 17, 2025
e447d7d
test_config.py tweak for type checks
jjuyeonkim Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pace/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,21 @@ def from_dict(cls, kwargs: Dict[str, Any]) -> "DriverConfig":
"as it is determined based on top-level configuration"
)

# TODO - After pyFV3 PR #88, replace dycore dacite cmd with:
# kwargs["dycore_config"] = DynamicalCoreConfig.from_dict(
# kwargs.get("dycore_config", {})
# )
dycore_dacite_config = dacite.Config(
strict=True,
type_hooks={
Tuple[int, int]: lambda x: tuple(x),
Tuple[str, ...]: lambda x: tuple(x) if x is not None else None,
},
)
kwargs["dycore_config"] = dacite.from_dict(
data_class=DynamicalCoreConfig,
data=kwargs.get("dycore_config", {}),
config=dacite.Config(strict=True),
config=dycore_dacite_config,
)

if isinstance(kwargs["physics_config"], dict):
Expand Down