Combination of 947,949,980 (MERRA2 3-hr, photochem diag, prog closure SFS)#990
Merged
Conversation
In particular, allow the ozone scheme to have two extra sets of parameters during the ozone hole without crashing the model.
With a separate index for each photochemistry scheme, we can move the index-finding calls in the conditional for the photochemistry scheme.
…dition. That was ufs-community/ccpp-physics#286, with corresponding PR NOAA-EMC#971 here.
14 tasks
Contributor
|
@grantfirl ufs-community/ccpp-physics#302 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@9ab7cba) and revert the .gitmodules file in preparation for the merge. |
jkbk2004
approved these changes
Jul 21, 2025
DusanJovic-NOAA
approved these changes
Jul 21, 2025
This was referenced Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a combination of the following:
#947 from @AnningCheng-NOAA
Enable 3-hourly forcing for MERRA2 data
#949 from @DWesl
Adds arrays to accumulate the water vapor photochemistry terms and write them out.
This PR should not change model output, but it will change water vapor diagnostics in the stratosphere and mesosphere to reflect changes from methane oxidation and photodissociation.
See original PR for more complete description
#980 from @lisa-bengtsson
Currently there is a dx threshold to not use the prognostic closure in saSAS convection for resolutions coarser than 30km. After testing and evaluation for the Seasonal Forecast System (SFS) linked here, we would like to activate this closure also for SFSv1. Thus, to be able to use this closure in SFS (~50km target) this threshold need to be made larger.
This pull-request will need new baselines for any coarser RT test than C384 using the saSAS convection scheme. It does not impact GFSv17 or GEFSv13 at C1152 or C384 resolution.
Issue(s) addressed
See ufs-community/ufs-weather-model#2813 for issues addressed by combined PRs.
Testing
Separate UFS RTs on Hera for each PR
Dependencies
ufs-community/ccpp-physics#302