Add qv photochemistry diagnostics#949
Closed
DWesl wants to merge 21 commits into
Closed
Conversation
DusanJovic-NOAA
changed the title
Collaborator
|
@DWesl I don't see a ufs-weather-model pull request for this work. Are you going to add one? |
Contributor
Author
Oh, right. What branch would that be against? |
Collaborator
It needs to go into develop. |
Closed
14 tasks
Contributor
Author
|
ufs-community/ufs-weather-model#2707 created to pull these changes into that repository. |
In particular, allow the ozone scheme to have two extra sets of parameters during the ozone hole without crashing the model.
With a separate index for each photochemistry scheme, we can move the index-finding calls in the conditional for the photochemistry scheme.
…dition. That was ufs-community/ccpp-physics#286, with corresponding PR NOAA-EMC#971 here.
Collaborator
|
Merged via #990 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds arrays to accumulate the water vapor photochemistry terms and write them out.
This PR should not change model output, but it will change water vapor diagnostics in the stratosphere and mesosphere to reflect changes from methane oxidation and photodissociation.
I should mention that one of the parameters gets called$-\frac{1}{\tau}(r-r_0)$ term it represents here is analagous to the $\left.\frac{\partial(P-L)}{\partial r}\right|_0 (r - r_0)$ ozone photochemistry diagnostic called
dtend_qv_ozmix, because thedtend_o3_ozmix. I don't know how to change the CCPP machinery to change the name of the diagnostic, nor what to change it to if I did.Issue(s) addressed
Testing
Dependencies