Allow photochemistry schemes to have parameters at different times.#286
Closed
DWesl wants to merge 3 commits into
Closed
Allow photochemistry schemes to have parameters at different times.#286DWesl wants to merge 3 commits into
DWesl wants to merge 3 commits into
Conversation
In particular, allow the ozone scheme to have two extra sets of parameters during the ozone hole without crashing the model.
This was referenced May 22, 2025
| call ozphys%update_o3prog(jindx1_o3, jindx2_o3, ddy_o3, rjday, n1, n2, ozpl) | ||
| endif | ||
|
|
||
| call find_photochemistry_index(h2ophys%ntime, h2ophys%time, rjday, n1, n2) |
There was a problem hiding this comment.
this line should move inside if (h2o_phys) then?
Author
There was a problem hiding this comment.
I moved all calls inside the relevant conditional, does that work?
With a separate index for each photochemistry scheme, we can move the index-finding calls in the conditional for the photochemistry scheme.
DWesl
requested review from
Qingfu-Liu,
dustinswales,
grantfirl and
rhaesung
as code owners
grantfirl
approved these changes
May 28, 2025
DWesl
added a commit
to DWesl/fv3atm
that referenced
this pull request
May 28, 2025
…dition. That was ufs-community/ccpp-physics#286, with corresponding PR NOAA-EMC#971 here.
DWesl
added a commit
to DWesl/ufs-weather-model
that referenced
this pull request
May 28, 2025
…dition. That was ufs-community/ccpp-physics#286 and NOAA-EMC/ufsatm#971, with corresponding PR ufs-community#2750 here.
Author
|
Merged into #265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, allow the ozone scheme to have two extra sets of parameters during the ozone hole without crashing the model.
An update to #223/#213 to keep the model from crashing after NOAA-EMC/global-workflow#3386