UFS-dev PR#302#614
Merged
Merged
Conversation
grantfirl
requested review from
dustinswales,
hertneky,
mkavulich and
scrasmussen
as code owners
hertneky
approved these changes
Aug 29, 2025
Collaborator
hertneky
left a comment
hertneky
left a comment
There was a problem hiding this comment.
Looks good
Tested locally on ursa gnu w/ rt_test_cases.py
Note for myself: baselines will need updates after this is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOURCE: @grantfirl
DESCRIPTION OF CHANGES:
ISSUE: None
ASSOCIATED PRs:
NCAR/ccpp-physics#1156
TESTS CONDUCTED: Tested in UFS RTs already. SCM RTs expect some results to change.
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
ufs-community/ccpp-physics#302
Associated fv3atm PR:
NOAA-EMC/ufsatm#990
Associated NCAR PR:
NCAR/ccpp-physics#1156
REGRESSION TEST CHANGES: Expected saSAS result changes. Also, photochemical diagnostic tendencies will change, so any case with non-zero ozone (all except BOMEX) will change results. BOMEX cases may not change results even if the suite uses saSAS because convection is not triggered.