CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90#936
Conversation
… in all suites, update driver/CCPP_driver.F90 accordingly
…p_prebuild_config.py
climbfuji
changed the title
…ture/split_sdf_physics_reset_ddts
|
@climbfuji Do you think it's ok to combine in #932 to this pr? At least, no baseline changes at the weather model level, I mean hera is down on maintenance today. So, we can take an advantage to schedule to let no baseline change PRs move on. |
Ok with me |
|
@climbfuji Can you sync this branch and I will pull it in? |
Why do I need to pull in updates that only forward the ccpp-physics submodule pointer? Your PR is changing that one, too. |
There are other changes in fv3atm develop that you need to bring into this branch, climbfuji/fv3atm@feature/split_sdf_physics_reset_ddts...NOAA-EMC:fv3atm:develop |
|
@climbfuji Nm. I pulled in your changes and resolved the conflicts. |
I saw you figured it out, thanks. |
|
@jkbk2004 Please let me know when I can close this and associated PRs, since @dustinswales absorbed them in his PRs (thanks Dustin). |
@climbfuji maybe around this afternoon. I will keep you posted when combined PRs get merged. |
…art Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #936 (#932) * Move to referencing contiguous data in GFS external diagnostic type * Updates to GFS_restart_type for contiguous arrays * Split group physics into physics_process_split and physics_time_split in all suites, update driver/CCPP_driver.F90 accordingly * Shorten physics_process_split as phys-ps, physics_time_split as phys-ts * Remove GFS_suite_interstial_{phys,rad}_reset schemes from all suites * Remove GFS_suite_interstitial_{phys,rad}_reset.* from ccpp/config/ccpp_prebuild_config.py --------- Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov>
|
merged with #932 |
6 participants
Description
capgen.py).GFS_interstitialDDT inCCPP_driver.F90instead of in the CCPP suites. This follows precedence of resetting the diagnostics (buckets) and removes the need to pass host-model DDTs into the physics (which breaks the paradigm of CCPP physics being host-model independent).Issue(s) addressed
This PR is part of the larger project of transitioning to the next-generation code generator
capgen.py.Testing
See ufs-community/ufs-weather-model#2651
Dependencies