Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #936#932
Merged
jkbk2004 merged 28 commits intoApr 2, 2025
Conversation
…ture/contiguous_arrays
…ture/contiguous_arrays
…ture/contiguous_arrays
…ture/contiguous_arrays
… in all suites, update driver/CCPP_driver.F90 accordingly
…p_prebuild_config.py
…ture/split_sdf_physics_reset_ddts
1 task
DusanJovic-NOAA
approved these changes
Mar 31, 2025
Collaborator
|
@dustinswales Can you try to combine in #936 to this pr? So, we can do some pre-test. |
Collaborator
Author
Collaborator
|
@dustinswales new hash for the physics is ufs-community/ccpp-physics@9cf24ca. Can you revert change in ,gitmodules as well? |
…swales/fv3atm into feature/contiguous_arrays
Collaborator
|
@dustinswales can you revert change in .gitmodules? |
Collaborator
@jkbk2004 Done |
jkbk2004
approved these changes
Apr 2, 2025
Collaborator
Author
Thanks @grantfirl |
jkbk2004
changed the title
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces using blocked data structures with contiguous data structures for external data types (GFS_diagnostics and GFS_restart). This work is a continuation of #798 and is described in UWM #2294.
Also, GFS_restart_type was refactored to be consistent with GFS_diagnostics_type. This simplifies the code and opens the possibility to unify some of the fv3 io modules.
Issue(s) addressed
UWM #2521
Testing
All UWM RTs pass on Hera and WCOSS.