Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #2651 + Hera move spack-stack to /contrib #2579

[dustinswales]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

• This PR contains updates to the fv3atm component to migrate from using blocked data structures to contiguous data structures. This work extends the effort of In fv3atm: convert GFS DDTs from blocked data structures to contiguous arrays #2183 and addresses Convert blocked data structures in FV3atm to contiguous arrays #2294.
• Update submodules fv3atm and ccpp-physics: split physics in two groups (process-split and time-split), reset GFS_interstitial DDT in CCPP_driver.F90 instead of in CCPP suite.
• Current spack-stack used by UFS-WM (1.6.0/fms-2024.01) is installed at new place:
  /contrib/spack-stack/spack-stack-1.6.0/envs/

Commit Message:

* UFSWM - Hera spack-stack migration to /contrib
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - Convert from using blocked data structures to contiguous data structures for the GFS external data types (GFS_diagnostics and GFS_restart).
  * FV3 - CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90
    * ccpp-physics - Remove GFS_suite_interstitial_{phys,rad}_reset.* (reset in fv3atm CCPP_driver.F90)
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

• Normal.

Git Tracking

UFSWM:

• Closes Convert blocked data structures in FV3atm to contiguous arrays #2294

Sub component Pull Requests:

• FV3: Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux NOAA-EMC/fv3atm #932
• FV3: CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 NOAA-EMC/ufsatm#936

UFSWM Blocking Dependencies:

• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• None

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • GaeaC5
  • GaeaC6
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[jkbk2004]

We can start merging process.

[jkbk2004]

@dustinswales new fv3 hash is NOAA-EMC/ufsatm@fbc09c9

[BrianCurtis-NOAA]

The title says: "Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #2651 + Hera move spack-stack to /contrib #2579"

Yet the PR description does not mention anything about CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 nor Hera move spack-stack to /contrib.

The git tracking does not include any links to the PR's added above. I don't even know if there are issues that those other PR's close that have not been added to this to be closed automatically on merge.

The commit message needs to remove any unused sections.

@jkbk2004 It's been mentioned a lot in the past, but to reiterate due to its importance, please be careful upon merging in PR's together to concatenate all information from all pieces into the one that will be merged. Ideally before final testing.

Prefer quality over quantity.

[jkbk2004]

@BrianCurtis-NOAA updated the description