Skip to content

CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90#2651

Closed
climbfuji wants to merge 10 commits into
ufs-community:developfrom
climbfuji:feature/split_sdf_physics_reset_ddts
Closed

CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90#2651
climbfuji wants to merge 10 commits into
ufs-community:developfrom
climbfuji:feature/split_sdf_physics_reset_ddts

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Mar 14, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers. CURRENTLY UNDER REVIEW
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules DONE ON HERA
  • Commit 'test_changes.list' from previous step

Description:

Update submodules fv3atm and ccpp-physics: split physics in two groups (process-split and time-split), reset GFS_interstitial DDT in CCPP_driver.F90 instead of in CCPP suite.

Commit Message:

* UFSWM - CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90
    * ccpp-physics - Remove GFS_suite_interstitial_{phys,rad}_reset.* (reset in fv3atm CCPP_driver.F90)
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

  • Normal.

Git Tracking

UFSWM:

  • None. This set of PRs is required for the transition to the next-generation CCPP framework code generator capgen.py (to replace ccpp_prebuild.py) in this calendar year.

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@climbfuji climbfuji self-assigned this Mar 14, 2025
@climbfuji climbfuji changed the title WIP: CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 Mar 14, 2025
@climbfuji climbfuji marked this pull request as ready for review March 17, 2025 01:06
@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Mar 17, 2025
Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes!
These changes will make it easier to decipher at the physics suite level how the state evolves.

jkbk2004 pushed a commit that referenced this pull request Apr 2, 2025
…art Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #2651 + Hera move spack-stack to /contrib #2579 (#2610)

* UFSWM - Hera spack-stack migration to /contrib
  * FV3 - Convert from using blocked data structures to contiguous data structures for the GFS external data types (GFS_diagnostics and GFS_restart).
  * FV3 - CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90
    * ccpp-physics - Remove GFS_suite_interstitial_{phys,rad}_reset.* (reset in fv3atm CCPP_driver.F90)
 
---------

Co-authored-by: Ratko Vasic <ratko.vasic@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Apr 2, 2025

merged with #2610

@jkbk2004 jkbk2004 closed this Apr 2, 2025
@climbfuji climbfuji deleted the feature/split_sdf_physics_reset_ddts branch April 10, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants