Skip to content

Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #936 #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkbk2004 merged 28 commits into from
Apr 2, 2025
Merged

Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux + CCPP updates in fv3atm/ccpp-physics: split physics in two groups, reset GFS_interstitial DDT in CCPP_driver.F90 #936 #932

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
376af8d
Move to referencing contiguous data in GFS external diagnostic type
dustinswales Dec 19, 2024
8e666b5
Stash before sync
dustinswales Feb 4, 2025
39cf9c5
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
dustinswales Feb 4, 2025
bf616cd
Bug
dustinswales Feb 4, 2025
93e8c12
Missing pieces!
dustinswales Feb 4, 2025
2fbce95
Small bugfix. Working. B4B
dustinswales Feb 4, 2025
d0b489b
Updates to GFS_restart_type for contiguous arrays
dustinswales Feb 6, 2025
f17693e
GFS_restart to contiguous.
dustinswales Feb 10, 2025
f3f6693
Some more changes
dustinswales Feb 10, 2025
c06dcf7
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
dustinswales Feb 10, 2025
83c13ff
Some changes to get all RTs runnnign
dustinswales Feb 11, 2025
f01c9fd
Move diagnostic zeroing into loop
dustinswales Feb 19, 2025
da0fe97
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
dustinswales Feb 19, 2025
c2cfcf4
Working meow
dustinswales Feb 19, 2025
0bf8f48
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
dustinswales Feb 19, 2025
f2622f6
Split group physics into physics_process_split and physics_time_split…
climbfuji Mar 13, 2025
2533e93
Bug fix in ccpp/driver/CCPP_driver.F90
DomHeinzeller Mar 13, 2025
9e02979
Shorten physics_process_split as phys-ps, physics_time_split as phys-ts
climbfuji Mar 14, 2025
13d12e0
Bug fix: phys-{ts,ps} --> phys_{ts,ps}
climbfuji Mar 14, 2025
cf29d05
Remove GFS_suite_interstial_{phys,rad}_reset schemes from all suites
climbfuji Mar 14, 2025
f2e5c2f
Remove GFS_suite_interstitial_{phys,rad}_reset.* from ccpp/config/ccp…
climbfuji Mar 14, 2025
60db3bc
Add missing OpenMP shared clause for GFS_Control in ccpp/driver/CCPP_…
climbfuji Mar 14, 2025
edeac14
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
climbfuji Mar 17, 2025
334b84a
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD
dustinswales Mar 31, 2025
f9bd0a4
Merge branch 'feature/split_sdf_physics_reset_ddts' of https://github…
dustinswales Mar 31, 2025
265dccf
Update physics hash
dustinswales Apr 2, 2025
4d984e1
Merge branch 'feature/contiguous_arrays' of https://github.com/dustin…
dustinswales Apr 2, 2025
63b9ec4
revert .gitmodules
grantfirl Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions atmos_model.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ module atmos_model_mod
! GFS containers
!----------------
type(GFS_externaldiag_type), target :: GFS_Diag(DIAG_SIZE)
type(GFS_restart_type) :: GFS_restart_var
type(GFS_restart_type) , allocatable, target :: GFS_restart_var(:)

!--------------
! IAU container
Expand Down Expand Up @@ -1023,7 +1023,7 @@ subroutine update_atmos_model_state (Atmos, rc)
call atmosphere_nggps_diag(Atmos%Time)
call fv3atm_diag_output(Atmos%Time, GFS_Diag, Atm_block, GFS_control%nx, GFS_control%ny, &
GFS_control%levs, 1, 1, 1.0_GFS_kind_phys, time_int, time_intfull, &
GFS_control%fhswr, GFS_control%fhlwr)
GFS_control%fhswr, GFS_control%fhlwr, GFS_control)
endif

!--- find current fhzero
Expand Down Expand Up @@ -1153,7 +1153,7 @@ subroutine atmos_model_restart(Atmos, timestamp)

if (quilting_restart) then
call fv_sfc_restart_output(GFS_sfcprop, Atm_block, GFS_control)
call fv_phy_restart_output(GFS_restart_var, Atm_block)
call fv_phy_restart_output(GFS_restart_var, Atm_block, GFS_Control)
call fv_dyn_restart_output(Atm(mygrid), timestamp)
else
call atmosphere_restart(timestamp)
Expand Down
Loading