Wrapper PR for "Remove optional arguments from CCPP metadata, remove effective radii computation from Thompson MP" and "Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions"#416
Merged
junwang-noaa merged 18 commits intoNov 4, 2021
Merged
Wrapper PR for "Remove optional arguments from CCPP metadata, remove effective radii computation from Thompson MP" and "Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions"#416junwang-noaa merged 18 commits into
junwang-noaa merged 18 commits into
Conversation
…p_convective_transport_tracers_cleanup
…pp/data/GFS_typedefs.meta
…ove_optional_arguments_from_ccpp
…p_convective_transport_tracers_cleanup
…p_convective_transport_tracers_cleanup
…ove_optional_arguments_from_ccpp
…p_convective_transport_tracers_cleanup
…ove_optional_arguments_from_ccpp
This was referenced Nov 2, 2021
Merged
climbfuji
changed the title
DusanJovic-NOAA
approved these changes
Nov 3, 2021
junwang-noaa
approved these changes
Nov 3, 2021
…ramework and ccpp-physics
Collaborator
Author
|
@DusanJovic-NOAA @junwang-noaa Please double-check the submodule pointer updates. I think this is ready to merge. |
Collaborator
|
ccpp submodule pointers are correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR combines #415 and #413:
#415:
This PR removes invalid
optionalandintentattributes from the CCPP metadata inGFS_typedefs.meta. Metadata for variable/derived data type definitions do not use these attributes (they do not make sense there), only CCPP schemes use(d) them.Submodule pointers for ccpp-framework and ccpp-physics are updated to remove support the
optionalattribute in the CCPP framework/metadata. The implementation ofoptionalin CCPP was always flaky and we now have a better way to deal with potentially unallocated variables (activeattribute).#413:
activeattribute for one variable inGFS_typedefs.metaand remove a legacy comment line inGFS_typedefs.F90Issue(s) addressed
Fixes NCAR/ccpp-framework#407
Fixes NCAR/ccpp-physics#751
Testing
See ufs-community/ufs-weather-model#892.
Associated PRs
NCAR/ccpp-framework#408
earth-system-radiation/rte-rrtmgp#143
NCAR/ccpp-physics#766
#416
ufs-community/ufs-weather-model#892
ESCOMP/ESMStandardNames#23