Fix/improve logic for convective transportable tracers in CCPP, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic"#413
Closed
climbfuji wants to merge 7 commits into
Conversation
…p_convective_transport_tracers_cleanup
This was referenced Oct 18, 2021
| dimensions = (horizontal_loop_extent) | ||
| type = real | ||
| kind = kind_phys | ||
| active = (flag_for_mellor_yamada_janic_surface_layer_scheme .or. flag_for_mellor_yamada_janic_pbl_scheme .or. (control_for_land_surface_scheme == identifier_for_noah_wrfv4_land_surface_scheme)) |
Collaborator
There was a problem hiding this comment.
'janic' should be spelled as 'janjic'
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching this. This turns out to be wrong in a few places. Will make the PR bigger but won't change the results.
Collaborator
Author
There was a problem hiding this comment.
Fixed, please have a look.
Collaborator
There was a problem hiding this comment.
Thanks for fixing this.
climbfuji
changed the title
DusanJovic-NOAA
approved these changes
Oct 19, 2021
junwang-noaa
approved these changes
Oct 19, 2021
…p_convective_transport_tracers_cleanup
…p_convective_transport_tracers_cleanup
…p_convective_transport_tracers_cleanup
Collaborator
Author
|
Superseded by #416. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
activeattribute for one variable inGFS_typedefs.metaand remove a legacy comment line inGFS_typedefs.F90Issue(s) addressed
Testing
For regression testing, see ufs-community/ufs-weather-model#875
Dependencies
NCAR/ccpp-physics#752
#413
ufs-community/ufs-weather-model#875