Remove invalid optional/intent attributes from DDT metadata#143
Merged
dustinswales merged 1 commit intoNov 3, 2021
Conversation
This was referenced Oct 25, 2021
This was referenced Nov 2, 2021
Contributor
Author
|
@dustinswales Please review this PR, if you can - we are hoping to merge this today. |
dustinswales
approved these changes
Nov 3, 2021
Contributor
Author
|
@dustinswales All tests passed, can you please merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CCPP metadata for defining derived data types (DDTs) does not use the
intentandoptionalattributes (they do not make sense when defining a DDT). This PR removes them.Associated PRs
NCAR/ccpp-framework#408
#143
NCAR/ccpp-physics#766
NOAA-EMC/ufsatm#416
ufs-community/ufs-weather-model#892
ESCOMP/ESMStandardNames#23
For regression testing with the UFS, see ufs-community/ufs-weather-model#892.