Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions#752
Conversation
…eneric_post_run to GFS_suite_interstitial_4_run (to be consistent with the corresponding logic in GFS_suite_interstitial_3_run
…nup-ccpp-october-2021
climbfuji
changed the title
| ! (which does have cloud ice, but for some reason it was decided to code it up | ||
| ! in the same way as for Zhao-Carr, nowadays unnecessary and confusing) needs | ||
| ! to be cleaned up. The convection schemes doing something different internally | ||
| ! based on clw(i,k,2) being -999.0 or not is not a good idea. |
There was a problem hiding this comment.
The original Zhao-Carr (it should really be called Zhao-Carr-Sundqvist-Moorthi was coded by me.
For one thing, it is not a pure Zhao-Carr - I combined Zhao-Carr and Sundqvist - obviously no one want to give me any credit for implementing this in GFS/CFS around the year 2000 and it had worked fine for about 16 years in GFS and still going on fine in CFSv2
There was a problem hiding this comment.
I am more than happy to add "Sundqvist-Moorthi" to any occurrence of "Zhao-Carr" in CCPP physics! In fact this is the first time that I heard about this. We'd need an acronym though, because "Zhao-Carr-Sundqvist-Moorthi" is rather long.
There was a problem hiding this comment.
Well, it it the first time because I refrained from commenting. Only the "ice" part of this is from Zhao -Carr. I went back to the original Sundqvist formulation for rain (part of Zhao-Carr is also based on Sundqvist). The original Zhao-Carr scheme was in our meso-scale model in the late 1990's - I imported it to global, but also modified it.
…_convective_transport_tracers_cleanup
climbfuji
changed the title
…_convective_transport_tracers_cleanup
…pp-physics into ccpp_convective_transport_tracers_cleanup
…_convective_transport_tracers_cleanup
…pp-physics into ccpp_convective_transport_tracers_cleanup
climbfuji
changed the title
…_convective_transport_tracers_cleanup
…al-arguments Wrapper PR for "Remove optional arguments from CCPP metadata, remove effective radii computation from Thompson MP" (#763) and "Fix/improve logic for convective transportable tracers, add GFS_checktracer debugging routine, correct spelling "janic" --> "janjic", fix inconsistent types related with noahmp and log functions" (#752)
4 participants
Description
Fixes #751 (see there).
This is achieved by moving the logic to reset the second entry of the
clwarray (in cases when only one tracer is used) fromGFS_SCNV_generic_post_runtoGFS_suite_interstitial_4_run.Also adds a new debugging scheme
GFS_checktracerstoGFS_debug.{F90,meta}that can be used to detect negative tracers almost anywhere in the suite definition file (except thefast_physicsgroup).Further: correct spelling "janic" --> "janjic" in a few CCPP standard names.
Also: contains the changes in PR #755 (fix inconsistent types related with noahmp and log functions) from @uturuncoglu. Fixes #750.
Associated PRs
#752
NOAA-EMC/ufsatm#413
ufs-community/ufs-weather-model#875
For regression testing, see ufs-community/ufs-weather-model#875