Address some compiler warnings in UFSATM#1025
Merged
Merged
Conversation
26 tasks
Collaborator
|
@NickSzapiro-NOAA Please add corresponding fv3_dycore PR as a dependency |
Collaborator
Author
|
Thanks @DusanJovic-NOAA. The ufsatm, ccpp-physics, and dycore changes are all independent, if need be |
Collaborator
|
Could we get approvals on this PR so that we can process its GFSv17 priority parent PR? (WM #2935) |
DusanJovic-NOAA
approved these changes
Oct 21, 2025
Contributor
|
@NickSzapiro-NOAA ufs-community/ccpp-physics#312 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@14f24db) and revert the .gitmodules file in preparation for the merge. |
Collaborator
|
@NickSzapiro-NOAA Same for NOAA-GFDL/GFDL_atmos_cubed_sphere#396. You can update the atmos_cubed_sphere submodule pointer to b0a1b09. |
Collaborator
Author
|
Sure. Please let me know if ok |
Collaborator
|
@NickSzapiro-NOAA It looks good to me! |
jkbk2004
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
One round of straight-forward fixes for some of the compiler warnings raised in compiling cpld_debug_gfsv17 to improve code quality and prepare for operational implementation
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
Tested via ufs-weather-model RTs and compile err logs with Intel and GNU compilers on Ursa
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
Have the ufs-weather-model regression test been run? On what platform? Yes, Ursa
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs