Skip to content

Address some compiler warnings in UFSATM #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkbk2004 merged 10 commits into from
Nov 4, 2025
Merged

Address some compiler warnings in UFSATM #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9cb5901
Update .gitmodules for acs, ccpp-physics
NickSzapiro-NOAA Oct 10, 2025
1c245f2
Fix explicit declaration compiler warnings
NickSzapiro-NOAA Oct 10, 2025
ce9ddba
Update hashes for ccpp/physics and atmos_cubed_sphere
NickSzapiro-NOAA Oct 10, 2025
20ed650
Update ccpp/physics hash
NickSzapiro-NOAA Oct 10, 2025
2b1a739
Re-add dropped Set IAU offset time in fv3/module_fcst_grid_comp.F90
NickSzapiro-NOAA Oct 15, 2025
299472b
Update ccpp/physics , fv3/acs
NickSzapiro-NOAA Nov 3, 2025
e1d5c0f
Merge develop into fix_warnings
NickSzapiro-NOAA Nov 3, 2025
7a8a921
use post_nems_routines in tests/test_post_nems_routines.F90
NickSzapiro-NOAA Nov 3, 2025
31c3763
Revert .gitmodules
NickSzapiro-NOAA Nov 4, 2025
5df191e
Update hash ccpp/physics fv3/atmos_cubed_sphere
NickSzapiro-NOAA Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ccpp/physics
Open in desktop
Submodule physics updated 4 files
+9 −9 physics/GWD/cires_ugwpv1_initialize.F90
+1 −0 physics/GWD/cires_ugwpv1_module.F90
+1 −0 physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90
+4 −13 physics/Interstitials/UFS_SCM_NEPTUNE/sfcsub.F
2 changes: 1 addition & 1 deletion fv3/atmos_cubed_sphere
Open in desktop
Submodule atmos_cubed_sphere updated 3 files
+2 −0 model/fv_arrays.F90
+10 −10 model/fv_regional_bc.F90
+52 −49 tools/fv_mp_mod.F90
8 changes: 4 additions & 4 deletions fv3/module_fcst_grid_comp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ subroutine fcst_initialize(fcst_comp, importState, exportState, clock, rc)

character(8) :: bundle_grid

real(kind=8) :: mpi_wtime, timeis
real(kind=8) :: timeis

type(ESMF_DELayout) :: delayout
type(ESMF_DistGrid) :: distgrid
Expand Down Expand Up @@ -1323,7 +1323,7 @@ subroutine fcst_run_phase_1(fcst_comp, importState, exportState,clock,rc)
integer,save :: dt_cap=0
type(ESMF_Time) :: currTime,stopTime
integer :: seconds
real(kind=8) :: mpi_wtime, tbeg1
real(kind=8) :: tbeg1
!
!-----------------------------------------------------------------------
!***********************************************************************
Expand Down Expand Up @@ -1390,7 +1390,7 @@ subroutine fcst_run_phase_2(fcst_comp, importState, exportState,clock,rc)
integer :: date(6), seconds
character(len=64) :: timestamp
integer :: unit
real(kind=8) :: mpi_wtime, tbeg1
real(kind=8) :: tbeg1
!
integer :: FBCount, i
logical :: isPresent
Expand Down Expand Up @@ -1498,7 +1498,7 @@ subroutine fcst_finalize(fcst_comp, importState, exportState,clock,rc)
!
integer :: unit
integer,dimension(6) :: date
real(kind=8) :: mpi_wtime, tbeg1
real(kind=8) :: tbeg1
!
!-----------------------------------------------------------------------
!***********************************************************************
Expand Down
1 change: 0 additions & 1 deletion io/module_wrt_grid_comp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,7 +1724,6 @@ subroutine wrt_run(wrt_comp, imp_state_write, exp_state_write,clock,rc)
real(ESMF_KIND_R8) :: geo_lon, geo_lat
real(ESMF_KIND_R8), parameter :: rtod=180.0/pi

real(kind=8) :: MPI_Wtime
real(kind=8) :: tbeg
real(kind=8) :: wbeg,wend

Expand Down
1 change: 1 addition & 0 deletions io/post_fv3.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ subroutine post_run_fv3(wrt_int_state,grid_id,mype,mpicomp,lead_write, &
lonstart,lonlast
use grib2_module, only : gribit2,num_pset,nrecout,first_grbtbl
use xml_perl_data,only : paramset
use post_nems_routines
!
!-----------------------------------------------------------------------
!
Expand Down
6 changes: 6 additions & 0 deletions io/post_nems_routines.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
module post_nems_routines
implicit none
contains

!-----------------------------------------------------------------------
!%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
!-----------------------------------------------------------------------
Expand Down Expand Up @@ -357,3 +361,5 @@ subroutine post_finalize(post_gribversion)
!
end subroutine post_finalize

end module post_nems_routines

1 change: 1 addition & 0 deletions tests/test_post_nems_routines.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ program test_post_nems_routines

use ctlblk_mod, only : komax,hyb_sigp,d3d_on,gocart_on, &
rdaod,nasa_on,gccpp_on,d2d_chem,modelname,submodelname, lsm
use post_nems_routines

implicit none

Expand Down
22 changes: 16 additions & 6 deletions ufsatm_cap.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ subroutine InitializeAdvertise(gcomp, rc)
use pio, only: PIO_IOTYPE_NETCDF, PIO_IOTYPE_PNETCDF
use pio, only: PIO_IOTYPE_NETCDF4C, PIO_IOTYPE_NETCDF4P
#endif
use mpi_f08, only: MPI_Wtime
type(ESMF_GridComp) :: gcomp
integer, intent(out) :: rc

Expand Down Expand Up @@ -232,7 +233,7 @@ subroutine InitializeAdvertise(gcomp, rc)
type(ESMF_Field), allocatable :: fieldList(:)

character(len=*),parameter :: subname='(ufsatm_cap:InitializeAdvertise)'
real(kind=8) :: MPI_Wtime, timeis, timerhs, time_rh_fb_start, time_rh_start
real(kind=8) :: timeis, timerhs, time_rh_fb_start, time_rh_start

integer :: wrttasks_per_group_from_parent, wrtLocalPet, num_threads
character(len=64) :: rh_filename
Expand Down Expand Up @@ -1330,6 +1331,8 @@ subroutine OutputHours_ArrayInput(noutput_fh,output_startfh)
end subroutine OutputHours_ArrayInput

subroutine InitializeRealize(gcomp, rc)
use mpi_f08, only : MPI_Wtime

type(ESMF_GridComp) :: gcomp
integer, intent(out) :: rc

Expand All @@ -1339,7 +1342,7 @@ subroutine InitializeRealize(gcomp, rc)
type(ESMF_State) :: importState, exportState
integer :: urc

real(8) :: MPI_Wtime, timeirs
real(8) :: timeirs

rc = ESMF_SUCCESS
timeirs = MPI_Wtime()
Expand Down Expand Up @@ -1367,10 +1370,12 @@ end subroutine InitializeRealize
!-----------------------------------------------------------------------------

subroutine ModelAdvance(gcomp, rc)

use mpi_f08, only : MPI_Wtime

type(ESMF_GridComp) :: gcomp
integer, intent(out) :: rc
real(kind=8) :: MPI_Wtime, timers
real(kind=8) :: timers

!-----------------------------------------------------------------------------

Expand All @@ -1396,6 +1401,8 @@ end subroutine ModelAdvance
!-----------------------------------------------------------------------------

subroutine ModelAdvance_phase1(gcomp, rc)
use mpi_f08, only : MPI_Wtime

type(ESMF_GridComp) :: gcomp
integer, intent(out) :: rc

Expand All @@ -1405,7 +1412,7 @@ subroutine ModelAdvance_phase1(gcomp, rc)
logical :: fcstpe
character(len=*),parameter :: subname='(ufsatm_cap:ModelAdvance_phase1)'
character(240) :: msgString
real(kind=8) :: MPI_Wtime, timep1rs, timep1re
real(kind=8) :: timep1rs, timep1re

!-----------------------------------------------------------------------------

Expand Down Expand Up @@ -1451,6 +1458,8 @@ end subroutine ModelAdvance_phase1
!-----------------------------------------------------------------------------

subroutine ModelAdvance_phase2(gcomp, rc)
use mpi_f08, only : MPI_Wtime

type(ESMF_GridComp) :: gcomp
integer, intent(out) :: rc

Expand All @@ -1470,7 +1479,7 @@ subroutine ModelAdvance_phase2(gcomp, rc)
type(ESMF_Clock) :: clock, clock_out
integer :: fieldCount

real(kind=8) :: MPI_Wtime, timep2rs
real(kind=8) :: timep2rs

character(len=ESMF_MAXSTR) :: fb_name
type(ESMF_Info) :: info
Expand Down Expand Up @@ -1767,6 +1776,7 @@ end subroutine TimestampExport_phase1
!-----------------------------------------------------------------------------

subroutine ModelFinalize(gcomp, rc)
use mpi_f08, only : MPI_Wtime

! input arguments
type(ESMF_GridComp) :: gcomp
Expand All @@ -1776,7 +1786,7 @@ subroutine ModelFinalize(gcomp, rc)
character(len=*),parameter :: subname='(ufsatm_cap:ModelFinalize)'
integer :: i, urc
type(ESMF_VM) :: vm
real(kind=8) :: MPI_Wtime, timeffs
real(kind=8) :: timeffs
!
!-----------------------------------------------------------------------------
!*** finialize forecast
Expand Down