Skip to content

Fix intel debug warnings (implicit i,j,k; explicit mpi interface)#396

Merged
vithikashah001 merged 2 commits into
NOAA-GFDL:dev/emcfrom
NickSzapiro-NOAA:fix_warnings
Nov 4, 2025
Merged

Fix intel debug warnings (implicit i,j,k; explicit mpi interface)#396
vithikashah001 merged 2 commits into
NOAA-GFDL:dev/emcfrom
NickSzapiro-NOAA:fix_warnings

Conversation

@NickSzapiro-NOAA
Copy link
Copy Markdown

Description

One round of straight-forward fixes for some of the compiler warnings raised in compiling cpld_debug_gfsv17 to improve code quality and prepare for operational implementation

Part of ufs-community/ufs-weather-model#2703

How Has This Been Tested?

Tested via ufs-weather-model RTs and compile err logs with Intel and GNU compilers on Ursa

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@gspetro-NOAA
Copy link
Copy Markdown

If there are atmos_cubed_sphere code managers available to approve this PR, it would be very helpful. The parent WM PR #2935 needs to be processed soon for GFS v17 retros.

Comment thread model/fv_arrays.F90
integer, intent(IN) :: is, ie, js, je, isd, ied, jsd, jed, npx, npy, npz, ng

integer :: i, j, k

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, we could also fix this in the main branch.

@gspetro-NOAA
Copy link
Copy Markdown

@vithikashah001 @JosephMouallem This PR is ready to merge. Testing is complete on WM parent PR #2935.

@JosephMouallem
Copy link
Copy Markdown
Contributor

@gspetro-NOAA Glad to hear, please let us know if you need anything else.

@gspetro-NOAA
Copy link
Copy Markdown

@JosephMouallem We need you or Vithika to perform the merge since we don't have permissions.

@vithikashah001 vithikashah001 merged commit b0a1b09 into NOAA-GFDL:dev/emc Nov 4, 2025
@gspetro-NOAA
Copy link
Copy Markdown

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants