Fix intel debug warnings (implicit i,j,k; explicit mpi interface)#396
Merged
Merged
Conversation
|
If there are atmos_cubed_sphere code managers available to approve this PR, it would be very helpful. The parent WM PR #2935 needs to be processed soon for GFS v17 retros. |
| integer, intent(IN) :: is, ie, js, je, isd, ied, jsd, jed, npx, npy, npz, ng | ||
|
|
||
| integer :: i, j, k | ||
|
|
Contributor
There was a problem hiding this comment.
great catch, we could also fix this in the main branch.
JosephMouallem
approved these changes
Oct 22, 2025
|
@vithikashah001 @JosephMouallem This PR is ready to merge. Testing is complete on WM parent PR #2935. |
Contributor
|
@gspetro-NOAA Glad to hear, please let us know if you need anything else. |
|
@JosephMouallem We need you or Vithika to perform the merge since we don't have permissions. |
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One round of straight-forward fixes for some of the compiler warnings raised in compiling cpld_debug_gfsv17 to improve code quality and prepare for operational implementation
Part of ufs-community/ufs-weather-model#2703
How Has This Been Tested?
Tested via ufs-weather-model RTs and compile err logs with Intel and GNU compilers on Ursa
Checklist:
Please check all whether they apply or not