Skip to content

Bring in nco DEBUG flag changes for ops #1475

Merged
mingchen-NOAA merged 3 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:pr1455debugflag2dev
Jul 28, 2025
Merged

Bring in nco DEBUG flag changes for ops #1475
mingchen-NOAA merged 3 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:pr1455debugflag2dev

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

Pull Request Summary

Bring in nco DEBUG flag changes for ops

The code changes were authored by @BrianCurtis-NOAA I am just pulling in the changes from #1455 (targeted to dev/ufs-weather-model) to the develop branch.

Description

NCO pushes for the two flags -check all -ftrapuv to be in as many components that go into operations as possible. We've added -check noarg_temp_created as it makes the logs much smaller.

Issue(s) addressed

Commit Message

  • Add -check all -check noarg_temp_created -ftrapuv flags to intel DEBUG builds

Check list

Testing

  • How were these changes tested? I first tested this branch in ufs-weather-model with the original Bring in nco DEBUG flag changes for ops #1455 code and no answer changes were found. I then ran the regular standalone matrix.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) not really b/c we don't use debug mode yet in standalone tests.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? yes hera intel
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    only the expected non-b4b
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    matrixCompFull.txt
    matrixCompSummary.txt
    matrixDiff.txt
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (12 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

@mingchen-NOAA mingchen-NOAA self-requested a review July 28, 2025 13:08
@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Regression tests and matrix comparisons on Orion Intel:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (12 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

No unexpected difference was observed.

@mingchen-NOAA mingchen-NOAA merged commit 1d58d7c into NOAA-EMC:develop Jul 28, 2025
3 of 6 checks passed
@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Regression tests and matrix comparisons are done and passed. I have merged the PR. Thank you @JessicaMeixner-NOAA @BrianCurtis-NOAA !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants