Skip to content

Update wcoss2.intel.lua#1142

Merged
RussTreadon-NOAA merged 18 commits into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/wcoss2_gdasapp
Jun 4, 2024
Merged

Update wcoss2.intel.lua#1142
RussTreadon-NOAA merged 18 commits into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/wcoss2_gdasapp

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jun 3, 2024

Make two changes to wcoss2.intel.lua

  1. replace para bufr/12.0.1 with prod bufr/12.0.1
  2. prepend git-lfs path to $PATH

Resolves #1139

RussTreadon-NOAA and others added 17 commits May 22, 2024 15:42
@RussTreadon-NOAA
add prod_util and para bufr/12.0.1 to wcoss2.intel modulefile (NOAA-E…
d171c72 
…MC#1111)
@RussTreadon-NOAA
correct modulefile syntax for wcoss2.intel (NOAA-EMC#1111)
0bc3cb5
@RussTreadon-NOAA
remove prod_util from wcoss2 module (NOAA-EMC#1111)
023b9e9
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into feature/wcoss2_gdasapp
c2405bd
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into feature/wcoss2_gdasapp
6ea0448
@RussTreadon-NOAA
add modules to wcoss2.intel, add wcoss2 to some soca tests (NOAA-EMC#…
f02a64d 
…1111)
@RussTreadon-NOAA
correct python norm error (NOAA-EMC#1111)
880ae32
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into feature/wcoss2_gdasapp
a84aab6
@RussTreadon-NOAA
Merge branch 'develop' into feature/wcoss2_gdasapp
439e8e9
@RussTreadon-NOAA
Merge branch 'develop' into feature/wcoss2_gdasapp
2f85c1f
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into feature/wcoss2_gdasapp
3aec0d6
@RussTreadon-NOAA
simplify wcoss2 logic in soca run_jjobs script (NOAA-EMC#1111)
a9c48c1
@RussTreadon-NOAA
initial commit of wcoss2 EVA module (NOAA-EMC#1111)
43ed3e7
@RussTreadon-NOAA
Merge branch 'develop' into feature/wcoss2_gdasapp
d2f1b99
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into feature/wcoss2_gdasapp
35a7544
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into feature/wcoss2_gdasapp
27d623a
@RussTreadon-NOAA
update wcoss2.intel module to use prod bufr/12.0.1 and add git-lfs pa…
1c34661 
…th (NOAA-EMC#1139)
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jun 3, 2024
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Jun 3, 2024

This PR will remain in draft mode until NCO installs the production bufr/12.0.1 on Cactus. As of 6/3/2024 bufr/12.0.1 has only been installed in production space on Dogwood.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Jun 4, 2024

bufr/12.0.1 is on Cactus as of 6/4/2024

russ.treadon@clogin02:~> module spider bufr

----------------------------------------------------------------------------------------------------------------------
  bufr:
----------------------------------------------------------------------------------------------------------------------
    Description:
      bufr library

     Versions:
        bufr/11.4.0
        bufr/11.5.0
        bufr/11.6.0
        bufr/11.7.0
        bufr/12.0.0
        bufr/12.0.1
     Other possible modules matches:
        bufr_dump  bufr_tranjb  bufr_util  compiler/intel/19.1.3.304/bufr_dump  core/bufr_dump

Therefore, mark this PR as Ready for review.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review June 4, 2024 09:49
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Jun 4, 2024

@CoryMartin-NOAA , @CatherineThomas-NOAA , @guillaumevernieres

We need at least bufr/12.0.1 to fully build GDASApp. NCO has installed bufr/12.0.1 on both Cactus and Dogwood in production directories. This PR updates modulefiles/GDAS/wcoss2.intel.lua to use the production bufr/12.0.1.

Once this PR is merged into develop, I will update the gdas.cd hash used by g-w PR #2620

CoryMartin-NOAA
CoryMartin-NOAA approved these changes Jun 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @RussTreadon-NOAA !

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Jun 4, 2024

Thank you @CoryMartin-NOAA for your approval. I'll merge the updated wcoss2.intel.lua into develop

@RussTreadon-NOAA RussTreadon-NOAA merged commit 3e50a8f into NOAA-EMC:develop Jun 4, 2024
CatherineThomas-NOAA
CatherineThomas-NOAA reviewed Jun 4, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's already merged, but just confirming that I can see the new module on both Cactus and Dogwood, and I was able to compile GDASApp with Russ's branch on Dogwood. Approve.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Jun 4, 2024

Thank you @CatherineThomas-NOAA for checking Dogwood and Cactus. I am currently running g-w CI for C96C48_ufs_hybatmDA on Cactus using the updated wcoss2.intel.lua.

danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge remote-tracking branch 'origin/develop' into feature/rename_atm
2ec1767 
* origin/develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'develop' into feature/move_jcb
09e652d 
* develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp
9cc594a 
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@RussTreadon-NOAA
Update wcoss2.intel.lua (#1142)
2d78392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA left review comments

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update wcoss2.intel.lua

3 participants

@RussTreadon-NOAA @CoryMartin-NOAA @CatherineThomas-NOAA