Skip to content

Fix ice water FV3 increment variable name and add a few more#1112

Merged
CoryMartin-NOAA merged 2 commits into
developfrom
feature/fv3inc_names
May 16, 2024
Merged

Fix ice water FV3 increment variable name and add a few more#1112
CoryMartin-NOAA merged 2 commits into
developfrom
feature/fv3inc_names

Conversation

@DavidNew-NOAA
Copy link
Copy Markdown
Collaborator

@DavidNew-NOAA DavidNew-NOAA commented May 16, 2024 •
edited
Loading

This PR corrects the name of ice water mixing ratio in the corresponding fields metadata YAML and adds a few more tracers. Many these additional tracers may never have increments, but I might as well add them just in case. (I got these tracers by putting a print statement in the UFS code when I was debugging my cubed-sphere increment reading branch)

@CoryMartin-NOAA CoryMartin-NOAA merged commit 3925f24 into develop May 16, 2024
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/fv3inc_names branch May 16, 2024 17:45
ypwang19 pushed a commit that referenced this pull request May 21, 2024
Merge remote-tracking branch 'origin/feature/superob_avg' into featur…
96e0e9c 
…e/superob_avg

* origin/feature/superob_avg:
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

RussTreadon-NOAA commented May 21, 2024

@DavidNew-NOAA and @CoryMartin-NOAA . This PR breaks g-w jobs gdasanalcalc and gfsanalcalc.

gsi_utils.fd src/netcdf_io/interp_inc.fd/driver.F90 hardwires the name of the cloud liquid ice water increment as icmr_inc on line 82 .

gfsanalcalc and gdasanalcalc abort with

 - PROCESS RECORD: icmr_inc

 FATAL ERROR: inquiring icmr_inc id for file=siginc.nc.06:
 NetCDF: Variable not found
 STOP.
999

While we could replace icmr_inc in driver.F90 with ice_wat_inc, doing so will break GSI cycling. The GSI writes the analysis increment file with icmr_inc. We need to add logic to driver.F90 to support both names.

grep -r icmr_inc in gsi_utils.fd/src/ caught src/EnKF/gfs/src/recentersigp.fd/recentersigp.f90 as another code which this PR will likely break. We execute recentersigp.x in the enkfgdasecen* jobs. It's easier to fix recentersigp.f90. icmr_inc appears in a case statement. We can add a new case statement for ice_wat_inc.

@DavidNew-NOAA
Copy link
Copy Markdown
Collaborator Author

DavidNew-NOAA commented May 21, 2024

@RussTreadon-NOAA Ah, sorry. I'll take a look at both codes and try to fix it

@DavidNew-NOAA DavidNew-NOAA mentioned this pull request May 21, 2024
Closed
@DavidNew-NOAA
Copy link
Copy Markdown
Collaborator Author

DavidNew-NOAA commented May 21, 2024

@RussTreadon-NOAA See NOAA-EMC/GSI-utils#43

@DavidNew-NOAA
Copy link
Copy Markdown
Collaborator Author

DavidNew-NOAA commented May 21, 2024

I'm perplexed though why GSI is using a different variable name than UFS for the ice increment.

DavidNew-NOAA added a commit that referenced this pull request May 22, 2024
@DavidNew-NOAA
Revert "Fix ice water FV3 increment variable name and add a few more (#…
e43069c 
…1112)"

This reverts commit 3925f24.
@DavidNew-NOAA DavidNew-NOAA mentioned this pull request May 22, 2024
Merged
CoryMartin-NOAA pushed a commit that referenced this pull request May 22, 2024
@DavidNew-NOAA
Revert "Fix ice water FV3 increment variable name and add a few more … (
0ed5dd6 
#1125)

…(#1112)"

This reverts commit 3925f24.

See comment here for why
NOAA-EMC/GSI-utils#43 (comment)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge remote-tracking branch 'origin/develop' into feature/rename_atm
2ec1767 
* origin/develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'develop' into feature/move_jcb
09e652d 
* develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp
9cc594a 
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
DavidNew-NOAA added a commit that referenced this pull request Jan 16, 2026
@DavidNew-NOAA
Fix ice water FV3 increment variable name and add a few more (#1112)
ad5cab8 
This PR corrects the name of ice water mixing ratio in the corresponding
fields metadata YAML and adds a few more tracers. Many these additional
tracers may never have increments, but I might as well add them just in
case. (I got these tracers by putting a print statement in the UFS code
when I was debugging my cubed-sphere increment reading branch)
DavidNew-NOAA added a commit that referenced this pull request Jan 16, 2026
@DavidNew-NOAA
Revert "Fix ice water FV3 increment variable name and add a few more … (
afb2c42 
#1125)

…(#1112)"

This reverts commit ad5cab8.

See comment here for why
NOAA-EMC/GSI-utils#43 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@danholdaway danholdaway Awaiting requested review from danholdaway

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidNew-NOAA @RussTreadon-NOAA @CoryMartin-NOAA