Skip to content

Feature/rtofs in situ#1110

Merged
guillaumevernieres merged 11 commits into
developfrom
feature/RTOFSInSitu
May 28, 2024
Merged

Feature/rtofs in situ#1110
guillaumevernieres merged 11 commits into
developfrom
feature/RTOFSInSitu

Conversation

@givelberg
Copy link
Copy Markdown
Collaborator

@givelberg givelberg commented May 15, 2024

Implemented a code that reads a binary RTOFS profile file that is generated by Fortran.
Once the file is read, temperature is ingested into an ioda file, along with longitude, latitude, temperature error data
and the date of the measurement.
Most of the code is in the new rtofs directory inside the obsproc directory.
A static library is generated.
An application needs to link against the rtofs library.
Accordingly, the files in the application folder have been updated.

apchoiCMD
apchoiCMD reviewed May 15, 2024
View reviewed changes
Comment thread utils/obsproc/CMakeLists.txt Outdated
apchoiCMD
apchoiCMD reviewed May 15, 2024
View reviewed changes
Comment thread utils/obsproc/RTOFSInSitu.h Outdated
apchoiCMD
apchoiCMD reviewed May 15, 2024
View reviewed changes
Comment thread utils/obsproc/rtofs/CMakeLists.txt Outdated
apchoiCMD
apchoiCMD reviewed May 15, 2024
View reviewed changes
Comment thread utils/obsproc/rtofs/RTOFSDataFile.cc Outdated
apchoiCMD
apchoiCMD reviewed May 15, 2024
View reviewed changes
Comment thread utils/test/testinput/gdas_rtofsinsitu.yaml
apchoiCMD
apchoiCMD reviewed May 15, 2024
View reviewed changes
Comment thread utils/obsproc/RTOFSInSitu.h Outdated
AndrewEichmann-NOAA
AndrewEichmann-NOAA reviewed May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, what Mindo said

Comment thread utils/obsproc/RTOFSInSitu.h
Comment thread utils/obsproc/applications/CMakeLists.txt Outdated
Comment thread utils/obsproc/rtofs/RTOFSOb.cc Outdated
guillaumevernieres
guillaumevernieres reviewed May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @givelberg , looks good, just a few cosmetic issues to sort out.

Comment thread utils/test/testinput/gdas_rtofsinsitu.yaml
Comment thread utils/obsproc/RTOFSInSitu.h Outdated
Comment thread utils/obsproc/rtofs/RTOFSOb.cc Outdated
guillaumevernieres
guillaumevernieres reviewed May 21, 2024
View reviewed changes
Comment thread utils/test/CMakeLists.txt
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels May 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels May 22, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue May 21 19:05:50 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue May 21 20:03:11 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue May 21 20:21:19 CDT 2024
Tests: 89% tests passed, 5 tests failed out of 45
	1768 - test_gdasapp_atm_jjob_var_run (Failed)
	1769 - test_gdasapp_atm_jjob_var_inc (Failed)
	1770 - test_gdasapp_atm_jjob_var_final (Failed)
	1772 - test_gdasapp_atm_jjob_ens_run (Failed)
	1773 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1110/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels May 22, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed May 22 00:14:59 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed May 22 01:04:22 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed May 22 01:25:49 UTC 2024
Tests: 89% tests passed, 5 tests failed out of 45
	1767 - test_gdasapp_atm_jjob_var_run (Failed)
	1768 - test_gdasapp_atm_jjob_var_inc (Failed)
	1769 - test_gdasapp_atm_jjob_var_final (Failed)
	1771 - test_gdasapp_atm_jjob_ens_run (Failed)
	1772 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1110/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels May 22, 2024
@guillaumevernieres guillaumevernieres merged commit f7c2260 into develop May 28, 2024
@guillaumevernieres guillaumevernieres deleted the feature/RTOFSInSitu branch May 28, 2024 13:28
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge remote-tracking branch 'origin/develop' into feature/rename_atm
2ec1767 
* origin/develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'develop' into feature/move_jcb
09e652d 
* develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp
9cc594a 
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@givelberg @guillaumevernieres
Feature/rtofs in situ (#1110)
80e1430 
Implemented a code that reads a binary RTOFS profile file that is
generated by Fortran.
Once the file is read, temperature is ingested into an ioda file, along
with longitude, latitude, temperature error data
and the date of the measurement.
Most of the code is in the new rtofs directory inside the obsproc
directory.
A static library is generated.
An application needs to link against the rtofs library.
Accordingly, the files in the application folder have been updated.

---------

Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA left review comments

@apchoiCMD apchoiCMD apchoiCMD left review comments

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees

No one assigned

Labels

hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@givelberg @emcbot @guillaumevernieres @AndrewEichmann-NOAA @apchoiCMD