Skip to content

Added YAML, JSON, python files for assimilating LEOGEO satwinds#1099

Merged
CoryMartin-NOAA merged 5 commits into
developfrom
feature/add_leogeo_satwinds
May 17, 2024
Merged

Added YAML, JSON, python files for assimilating LEOGEO satwinds#1099
CoryMartin-NOAA merged 5 commits into
developfrom
feature/add_leogeo_satwinds

Conversation

@BrettHoover-NOAA
Copy link
Copy Markdown
Collaborator

@BrettHoover-NOAA BrettHoover-NOAA commented May 8, 2024 •
edited
Loading

Adding satwinds from the low-Earth orbiting / geostationary (LEOGEO) from multiple satellite platforms to GDASApp end-to-end testing

new files include:
parm/ioda/bufr2ioda/bufr2ioda_satwind_amv_leogeo.json: JSON containing data format, sensor, and satellite information for LEOGEO satwinds
ush/ioda/bufr2ioda/bufr2ioda_satwind_amv_leogeo.py: bufr2ioda code for extracting LEOGEO satwinds from BUFR

Dependent PR to NOAA-EMC/jcb-gdas
parm/atm/obs/config/satwnd.leogeo_multi.yaml.j2: QC filter YAML for LEOGEO satwinds (jinja2 standard) - this file is part of NOAA-EMC/jcb-gdas#4

See #1098 for end-to-end testing results. Acceptance and ob-errors agree well with some expected deviation. No thinning is applied to these winds by regular convention.

Note: We are still using qualityInformationWithoutForecast as the variable-name for QI in the IODA converter. This variable-name is currently not registered in the IODA ObsSpace.yaml, but there is an ongoing discussion with JCSDA to have it added, issue is here: https://github.com/JCSDA-internal/ioda/issues/1233

@BrettHoover-NOAA BrettHoover-NOAA self-assigned this May 8, 2024
CoryMartin-NOAA
CoryMartin-NOAA reviewed May 9, 2024
View reviewed changes
Comment thread parm/atm/obs/config/satwind_leogeo_multi.yaml.j2 Outdated
@BrettHoover-NOAA BrettHoover-NOAA marked this pull request as draft May 9, 2024 15:26
nicholasesposito
nicholasesposito approved these changes May 13, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nicholasesposito nicholasesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looked good to me

@BrettHoover-NOAA BrettHoover-NOAA mentioned this pull request May 13, 2024
Merged
@BrettHoover-NOAA
Copy link
Copy Markdown
Collaborator Author

BrettHoover-NOAA commented May 13, 2024

Reopening this PR with NOAA-EMC/jcb-gdas#4 to add QC YAML in NOAA-EMC/jcb-gdas

@BrettHoover-NOAA BrettHoover-NOAA marked this pull request as ready for review May 13, 2024 17:54
@CoryMartin-NOAA CoryMartin-NOAA merged commit e87e2c9 into develop May 17, 2024
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/add_leogeo_satwinds branch May 17, 2024 15:51
ypwang19 pushed a commit that referenced this pull request May 21, 2024
Merge remote-tracking branch 'origin/feature/superob_avg' into featur…
96e0e9c 
…e/superob_avg

* origin/feature/superob_avg:
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge remote-tracking branch 'origin/develop' into feature/rename_atm
2ec1767 
* origin/develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'develop' into feature/move_jcb
09e652d 
* develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
@danholdaway
Merge branch 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp
9cc594a 
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@BrettHoover-NOAA
Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
621921a 
Adding satwinds from the low-Earth orbiting / geostationary (LEOGEO)
from multiple satellite platforms to GDASApp end-to-end testing

new files include:
parm/ioda/bufr2ioda/bufr2ioda_satwind_amv_leogeo.json: JSON containing
data format, sensor, and satellite information for LEOGEO satwinds
ush/ioda/bufr2ioda/bufr2ioda_satwind_amv_leogeo.py: bufr2ioda code for
extracting LEOGEO satwinds from BUFR

**Dependent PR to NOAA-EMC/jcb-gdas**
parm/atm/obs/config/satwnd.leogeo_multi.yaml.j2: QC filter YAML for
LEOGEO satwinds (jinja2 standard) - this file is part of
NOAA-EMC/jcb-gdas#4

See #1098 for end-to-end testing results. Acceptance and ob-errors agree
well with some expected deviation. No thinning is applied to these winds
by regular convention.

Note: We are still using qualityInformationWithoutForecast as the
variable-name for QI in the IODA converter. This variable-name is
currently not registered in the IODA ObsSpace.yaml, but there is an
ongoing discussion with JCSDA to have it added, issue is here:
JCSDA-internal/ioda#1233

---------

Co-authored-by: Brett Hoover <bhoover@Orion-login-1.HPC.MsState.Edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danholdaway danholdaway danholdaway left review comments

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@nicholasesposito nicholasesposito nicholasesposito approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

@emilyhcliu emilyhcliu Awaiting requested review from emilyhcliu

@ADCollard ADCollard Awaiting requested review from ADCollard

@azadeh-gh azadeh-gh Awaiting requested review from azadeh-gh

@PraveenKumar-NOAA PraveenKumar-NOAA Awaiting requested review from PraveenKumar-NOAA

@XuanliLi-NOAA XuanliLi-NOAA Awaiting requested review from XuanliLi-NOAA

@xincjin-NOAA xincjin-NOAA Awaiting requested review from xincjin-NOAA

Assignees

@BrettHoover-NOAA BrettHoover-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrettHoover-NOAA @CoryMartin-NOAA @danholdaway @nicholasesposito